gitea/act_runner
62
108
Fork 81
Code Issues 139 Pull Requests 10 Actions Releases 21 Activity

Improve the usage of docker_host configuration #260

Merged
wolfogre merged 4 commits from Zettat123/act_runner:improve-docker-host into main 2023-06-30 04:00:07 +00:00
Conversation 0 Commits 4 Files Changed 4 +62 -29
Zettat123 commented 2023-06-28 10:18:11 +00:00
Member
Copy Link

Follow #242, #244
Fixes #258

Users could use docker_host configuration to specify which docker daemon will be used by act_runner.

  • If docker_host is empty, act_runner will find an available docker host automatically.
  • If docker_host is "-", act_runner will find an available docker host automatically, but the docker host won't be mounted to the job containers and service containers.
  • If docker_host is not empty or "-", the specified docker host will be used. An error will be returned if it doesn't work.
Follow #242, #244 Fixes #258 Users could use `docker_host` configuration to specify which docker daemon will be used by act_runner. - If `docker_host` is **empty**, act_runner will find an available docker host automatically. - If `docker_host` is **"-"**, act_runner will find an available docker host automatically, but the docker host won't be mounted to the job containers and service containers. - If `docker_host` is **not empty or "-"**, the specified docker host will be used. An error will be returned if it doesn't work.
Zettat123 added 1 commit 2023-06-28 10:18:14 +00:00
set ContainerDaemonSocket as docker_host
All checks were successful
checks / check and test (pull_request) Successful in 1m21s
Details
e5e4e3a113
Zettat123 added the
kind
bug
 label 2023-06-28 10:18:37 +00:00
Zettat123 added 1 commit 2023-06-29 04:28:22 +00:00
add TODO
All checks were successful
checks / check and test (pull_request) Successful in 41s
Details
06f0ce2f51
Zettat123 changed title from WIP: Improve the usage of `docker_host` configuration to Improve the usage of `docker_host` configuration 2023-06-29 04:34:29 +00:00
Zettat123 changed title from Improve the usage of `docker_host` configuration to Improve the usage of `docker_host` configuration 2023-06-29 04:34:30 +00:00
Zettat123 changed title from Improve the usage of `docker_host` configuration to WIP: Improve the usage of `docker_host` configuration 2023-06-29 10:27:33 +00:00
Zettat123 added 1 commit 2023-06-30 02:53:45 +00:00
simplify finding docker socket
All checks were successful
checks / check and test (pull_request) Successful in 38s
Details
c6d75e0ab2
Zettat123 changed title from WIP: Improve the usage of `docker_host` configuration to Improve the usage of `docker_host` configuration 2023-06-30 03:18:27 +00:00
wolfogre approved these changes 2023-06-30 03:41:17 +00:00
wolfogre left a comment
Owner
Copy Link

LGTM, just some a problem about code style.

LGTM, just some a problem about code style.
internal/app/cmd/docker_deamon.go Outdated
@ -0,0 +8,4 @@
"os"
)
func getDockerSocketPath(configDockerHost string) (string, error) {
wolfogre commented 2023-06-30 03:40:09 +00:00
Owner
Copy Link

The functions body code smells bad.

Please change it to

if xx {
	return
}
if yy {
	return
}
return
The functions body code smells bad. Please change it to ``` if xx { return } if yy { return } return ```
👍 1
Zettat123 commented 2023-06-30 03:56:38 +00:00
Author
Member
Copy Link

fixed in ba20ddb2f7

fixed in ba20ddb2f7789bfcdd36658dddb17d54419d0a8e
Zettat123 marked this conversation as resolved
Zettat123 added 1 commit 2023-06-30 03:52:19 +00:00
move getDockerSocketPath to daemon.go
All checks were successful
checks / check and test (pull_request) Successful in 3m14s
Details
ba20ddb2f7
wolfogre merged commit ccc27329dc into main 2023-06-30 04:00:07 +00:00
Zettat123 deleted branch improve-docker-host 2023-06-30 04:03:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
wolfogre
Labels
Clear labels   
kind
bug
Something is not working

  
kind
build

  
kind/compatible
  
kind
dependencies

  
kind
docs

  
kind
enhancement
New feature

  
kind
feature

  
kind
help wanted
Need some help

  
kind
proposal

  
kind
refactor

  
related
act
Related to act.

  
related
environment
Related to the environment.

  
related
exec

  
related
gitea
Related to Gitea.

  
related
workflow
Related to the workflow file or actions scripts.

  
reviewed
confirmed
confirmed issue

  
reviewed
duplicate
This issue or pull request already exists

  
reviewed
invalid
Something is wrong

  
reviewed
needs feedback

  
reviewed
wontfix
This won't be fixed

  
reviewed
workaround

No Label
kind
bug
kind
build
kind/compatible
kind
dependencies
kind
docs
kind
enhancement
kind
feature
kind
help wanted
kind
proposal
kind
refactor
related
act
related
environment
related
exec
related
gitea
related
workflow
reviewed
confirmed
reviewed
duplicate
reviewed
invalid
reviewed
needs feedback
reviewed
wontfix
reviewed
workaround
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/act_runner#260
No description provided.
Delete Branch "Zettat123/act_runner:improve-docker-host"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?