gitea/act_runner
61
107
Fork 80
Code Issues 139 Pull Requests 10 Actions 1 Releases 21 Activity

fix: Exit docker container on any process exit #462

Merged
lunny merged 2 commits from davidfrickert/act_runner:fix/docker-exit-on-error into main 2024-01-30 13:47:43 +00:00
Conversation 1 Commits 2 Files Changed 2 +5 -1
davidfrickert commented 2024-01-11 19:03:21 +00:00
Contributor
Copy Link

Description

Issue described in #460

Changes

  • Edited supervisord.conf to exit if it detects any of the supervisored processes exiting.
  • minor text fix

Notes

Without this change (or something similar), if act_runner fails, then the container will stay up as a zombie container - it does nothing and does not restart. After this change, if act_runner fails (e.g. due to Gitea instance being down), then supervisord will exit and the container will be restarted.

## Description Issue described in #460 ## Changes - Edited `supervisord.conf` to exit if it detects any of the supervisored processes exiting. - minor text fix ## Notes Without this change (or something similar), if act_runner fails, then the container will stay up as a zombie container - it does nothing and does not restart. After this change, if act_runner fails (e.g. due to Gitea instance being down), then supervisord will exit and the container will be restarted.
davidfrickert added 2 commits 2024-01-11 19:03:22 +00:00
fix: Allow supervisord to exit if act_runner or docker processes error 
- This fixes the issue where act_runner daemon command fails, for example due to gitea instance being unavailable but supervisord process still stays running so you essentially have a zombie container.
- With this fix, supervisord will exit if it detects any unexpected process exits - making so that the container will restart cleanly and not go into zombie mode.
#460
All checks were successful
checks / check and test (pull_request) Successful in 1m16s
Details
ebb724fef3
toastedcrumpets commented 2024-01-29 22:15:44 +00:00
First-time contributor
Copy Link

LGTM!

LGTM!
lunny approved these changes 2024-01-30 13:47:26 +00:00
lunny merged commit f1f9142a3c into main 2024-01-30 13:47:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lunny
Labels
Clear labels   
kind
bug
Something is not working

  
kind
build

  
kind/compatible
  
kind
dependencies

  
kind
docs

  
kind
enhancement
New feature

  
kind
feature

  
kind
help wanted
Need some help

  
kind
proposal

  
kind
refactor

  
related
act
Related to act.

  
related
environment
Related to the environment.

  
related
exec

  
related
gitea
Related to Gitea.

  
related
workflow
Related to the workflow file or actions scripts.

  
reviewed
confirmed
confirmed issue

  
reviewed
duplicate
This issue or pull request already exists

  
reviewed
invalid
Something is wrong

  
reviewed
needs feedback

  
reviewed
wontfix
This won't be fixed

  
reviewed
workaround

No Label
kind
bug
kind
build
kind/compatible
kind
dependencies
kind
docs
kind
enhancement
kind
feature
kind
help wanted
kind
proposal
kind
refactor
related
act
related
environment
related
exec
related
gitea
related
workflow
reviewed
confirmed
reviewed
duplicate
reviewed
invalid
reviewed
needs feedback
reviewed
wontfix
reviewed
workaround
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/act_runner#462
No description provided.
Delete Branch "davidfrickert/act_runner:fix/docker-exit-on-error"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?