Use artifacts v4 jwt if available #471
Labels
No Label
kind
bug
kind
build
kind/compatible
kind
dependencies
kind
docs
kind
enhancement
kind
feature
kind
help wanted
kind
proposal
kind
refactor
related
act
related
environment
related
exec
related
gitea
related
workflow
reviewed
confirmed
reviewed
duplicate
reviewed
invalid
reviewed
needs feedback
reviewed
wontfix
reviewed
workaround
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitea/act_runner#471
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "ChristopherHX/act_runner:jwt-runtime-token"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Needs https://github.com/go-gitea/gitea/pull/28885 to provide jwt if sent by server
Could fix #459, but that has not been verified.
Need to look into masking the new secretShould be masked now in this PR.b56fedff6e
to58a3ef40e8
Which of the PRs must be merged first?
Or is the order irrelevant?
How are runners on old instances handled?
To me as a relative outsider, it looks like the map would return
null
in this case, thus letting the runner panic asnull
has noGetStringValue()
.Yes the order is irrelevant.
Old Gitea Instances are handled by using the old token for artifacts v3
Old runners are handled like this
act_runner just drops the jwt field if it is older.
Also the old token will continue to work with artifacts v3
Yes this is true
No panic, just an empty string
The last time I looked into this
GetStringValue
isn't virtual (interface method are virtual) and don't do any lookup based on the this object.GetStringValue call GetKind and handles the conversion error
3068604084/types/known/structpb/struct.pb.go (L495)
GetKind handles the nil case
3068604084/types/known/structpb/struct.pb.go (L474)
BTW in go is a typed nil of a struct not the same as a nil of type interface{} / other interfaces