gitea/act_runner
61
107
Fork 80
Code Issues 139 Pull Requests 10 Actions 1 Releases 21 Activity

Exit with Code 1 if registering a runner fails #228

Merged
techknowlogick merged 6 commits from MarkusLoeffler01/act_runner:main into main 2023-06-09 17:34:25 +00:00
Conversation 1 Commits 6 Files Changed 1 +2 -3
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/app/cmd/register.go
View File

@ -197,7 +197,7 @@ func registerInteractive(configFile string) error {
if stage == StageWaitingForRegistration {
log.Infof("Registering runner, name=%s, instance=%s, labels=%v.", inputs.RunnerName, inputs.InstanceAddr, inputs.CustomLabels)
if err := doRegister(cfg, inputs); err != nil {
log.Errorf("Failed to register runner: %v", err)
return fmt.Errorf("Failed to register runner: %w", err)
} else {
MarkusLoeffler01 marked this conversation as resolved Outdated
techknowlogick commented 2023-06-05 17:22:41 +00:00
Outdated
Review
Copy Link

thanks for this PR. You may be able to return an error, and Cobra would exit with a non-zero status, I haven't tested this suggestion though.

thanks for this PR. You may be able to return an error, and Cobra would exit with a non-zero status, I haven't tested this suggestion though.
wolfogre commented 2023-06-06 03:28:15 +00:00
Outdated
Review
Copy Link

Maybe:

				return fmt.Errorf("Failed to register runner: %w", err)
Maybe: ```go return fmt.Errorf("Failed to register runner: %w", err) ```
log.Infof("Runner registered successfully.")
}
@ -257,8 +257,7 @@ func registerNoInteractive(configFile string, regArgs *registerArgs) error {
return nil
}
if err := doRegister(cfg, inputs); err != nil {
log.Errorf("Failed to register runner: %v", err)
return nil
return fmt.Errorf("Failed to register runner: %w", err)
}
techknowlogick marked this conversation as resolved Outdated
wolfogre commented 2023-06-06 03:28:48 +00:00
Outdated
Review
Copy Link

Ditto.

Ditto.
log.Infof("Runner registered successfully.")
return nil