gitea/actions-proto-def
43
6
Fork 4
Code Issues 1 Pull Requests Actions Releases 1 Activity

Reduce unnecessary DB queries for Actions tasks #10

Merged
lunny merged 5 commits from sillyguodong/actions-proto-def:feature/fetch_with_task_index into main 2023-06-12 08:16:27 +00:00
Conversation 0 Commits 5 Files Changed 1 +4 -1
sillyguodong commented 2023-05-29 02:01:14 +00:00
Member
Copy Link

implement: https://github.com/go-gitea/gitea/issues/24544

Changes:

  • Add tasks_version in FetchTaskResponse to store the latest version number that Gitea returns to Runner.
  • Add tasks_version in FetchTaskRequest to store the latest version number of Runner when executing fetchTask.

Related:

implement: https://github.com/go-gitea/gitea/issues/24544 Changes: - Add `tasks_version` in `FetchTaskResponse` to store the latest version number that Gitea returns to Runner. - Add `tasks_version` in `FetchTaskRequest` to store the latest version number of Runner when executing `fetchTask`. Related: - Runner side: https://gitea.com/gitea/act_runner/pulls/219 - Gitea side: https://github.com/go-gitea/gitea/pull/25199
sillyguodong added 1 commit 2023-05-29 02:01:16 +00:00
fetch task with index
Some checks failed
checks / check and test (pull_request) Failing after 1m30s
Details
35c2445c5e
sillyguodong added 1 commit 2023-06-07 01:47:17 +00:00
change to version
All checks were successful
checks / check and test (pull_request) Successful in 1m33s
Details
8ddca73d92
sillyguodong added 1 commit 2023-06-12 05:43:13 +00:00
Merge branch 'main' into feature/fetch_with_task_index
All checks were successful
checks / check and test (pull_request) Successful in 1m55s
Details
ab0d1198a5
sillyguodong changed title from WIP: Reduce unnecessary DB queries for Actions tasks to Reduce unnecessary DB queries for Actions tasks 2023-06-12 05:43:32 +00:00
wolfogre reviewed 2023-06-12 07:05:34 +00:00
proto/runner/v1/messages.proto Outdated
@ -29,2 +29,3 @@
message FetchTaskRequest {}
message FetchTaskRequest {
int64 task_version = 1;
wolfogre commented 2023-06-12 06:56:41 +00:00
Owner
Copy Link

task_version does't look good to me. It's not "the version of a task."

I don't have a good idea, but maybe tasks_version could be better? It's the version of whole tasks data.

`task_version` does't look good to me. It's not "the version of a task." I don't have a good idea, but maybe `tasks_version` could be better? It's the version of whole tasks data.
sillyguodong marked this conversation as resolved
sillyguodong added 1 commit 2023-06-12 07:25:16 +00:00
use tasks_version
All checks were successful
checks / check and test (pull_request) Successful in 1m21s
Details
93700ef3e5
sillyguodong added 1 commit 2023-06-12 07:35:09 +00:00
add comment
All checks were successful
checks / check and test (pull_request) Successful in 1m17s
Details
cca27119e2
wolfogre approved these changes 2023-06-12 07:58:40 +00:00
wolfogre approved these changes 2023-06-12 07:59:38 +00:00
lunny approved these changes 2023-06-12 08:16:08 +00:00
lunny merged commit f2983b1900 into main 2023-06-12 08:16:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
wolfogre
lunny
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
proposal

   
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
proposal
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/actions-proto-def#10
No description provided.
Delete Branch "sillyguodong/actions-proto-def:feature/fetch_with_task_index"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?