gitea/blog
44
20
Fork 31
Code Issues 10 Pull Requests 4 Actions Activity

dynamic release cover image (#285) #287

Merged
delvh merged 4 commits from denyskon/blog:dynamic-release-image into main 2023-08-05 20:14:16 +00:00
Conversation 4 Commits 4 Files Changed 125 +170 -12
denyskon commented 2023-07-29 20:04:55 +00:00
Member
Copy Link

See #285
This time with (hopefully...) fixed CSP & fonts.

See #285 This time with (hopefully...) fixed CSP & fonts.
denyskon added 3 commits 2023-07-29 20:04:59 +00:00
add dynamic release cover image
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 2m28s
Details
delete closed PR preview s3 / delete_preview (pull_request) Successful in 20s
Details
8b0d0279e1
fix csp errors
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 2m28s
Details
e7d696e78c
delvh commented 2023-07-29 20:37:51 +00:00
Owner
Copy Link

Wait, the difference to before is simply that you inline the image further?
And that fixes anything?

Wait, the difference to before is simply that you inline the image further? And that fixes anything?
delvh commented 2023-07-29 20:39:00 +00:00
Owner
Copy Link

Also, if this approach really works, please add a comment to discourage future developers from breaking again by using the already present SVG instead.

Also, if this approach really works, please add a comment to discourage future developers from breaking again by using the already present SVG instead.
denyskon commented 2023-07-29 20:43:14 +00:00
Author
Member
Copy Link

The solution is to write the style parameters directly into the tag instead of inserting them as an inline style.

<g textAlign="center">

instead of

<g style="text-align: center;">

And I needed to inline the logo because it also contains a style tag. Another option would be to change the logo svg though if that's preferred....

The solution is to write the style parameters directly into the tag instead of inserting them as an inline style. ```xml <g textAlign="center"> ``` instead of ```xml <g style="text-align: center;"> ``` And I needed to inline the logo because it also contains a style tag. Another option would be to change the logo svg though if that's preferred....
denyskon added 1 commit 2023-07-29 20:53:23 +00:00
use existing logo svg
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 2m32s
Details
delete closed PR preview s3 / delete_preview (pull_request) Successful in 19s
Details
132bfa97c8
delvh approved these changes 2023-08-03 21:28:57 +00:00
delvh left a comment
Owner
Copy Link

Let's see if it'll work.
In the worst case, we'll revert again.

Let's see if it'll work. In the worst case, we'll revert again.
lunny approved these changes 2023-08-05 10:09:33 +00:00
delvh commented 2023-08-05 20:14:02 +00:00
Owner
Copy Link

Let's see if it'll work.

Let's see if it'll work.
delvh merged commit d9f499f9e7 into main 2023-08-05 20:14:16 +00:00
denyskon deleted branch dynamic-release-image 2023-08-05 20:57:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
delvh
lunny
Labels
Clear labels   
in progress

   
kind/bug

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
lgtm/done

   
lgtm/need 1

   
lgtm/need 2

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
status/blocked

   
status/needs-feedback

   
status/wip
No Label
in progress
kind/bug
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/security
kind/testing
kind/translation
kind/ui
lgtm/done
lgtm/need 1
lgtm/need 2
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
status/blocked
status/needs-feedback
status/wip
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/blog#287
No description provided.
Delete Branch "denyskon/blog:dynamic-release-image"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?