dynamic release cover image (#285) #287

Merged
delvh merged 4 commits from denyskon/blog:dynamic-release-image into main 2023-08-05 20:14:16 +00:00
Member

See #285
This time with (hopefully...) fixed CSP & fonts.

See #285 This time with (hopefully...) fixed CSP & fonts.
denyskon added 3 commits 2023-07-29 20:04:59 +00:00
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 2m28s
delete closed PR preview s3 / delete_preview (pull_request) Successful in 20s
8b0d0279e1
add dynamic release cover image
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 2m28s
e7d696e78c
fix csp errors
Owner

Wait, the difference to before is simply that you inline the image further?
And that fixes anything?

Wait, the difference to before is simply that you inline the image further? And that fixes anything?
Owner

Also, if this approach really works, please add a comment to discourage future developers from breaking again by using the already present SVG instead.

Also, if this approach really works, please add a comment to discourage future developers from breaking again by using the already present SVG instead.
Author
Member

The solution is to write the style parameters directly into the tag instead of inserting them as an inline style.

<g textAlign="center">

instead of

<g style="text-align: center;">

And I needed to inline the logo because it also contains a style tag. Another option would be to change the logo svg though if that's preferred....

The solution is to write the style parameters directly into the tag instead of inserting them as an inline style. ```xml <g textAlign="center"> ``` instead of ```xml <g style="text-align: center;"> ``` And I needed to inline the logo because it also contains a style tag. Another option would be to change the logo svg though if that's preferred....
denyskon added 1 commit 2023-07-29 20:53:23 +00:00
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 2m32s
delete closed PR preview s3 / delete_preview (pull_request) Successful in 19s
132bfa97c8
use existing logo svg
delvh approved these changes 2023-08-03 21:28:57 +00:00
delvh left a comment
Owner

Let's see if it'll work.
In the worst case, we'll revert again.

Let's see if it'll work. In the worst case, we'll revert again.
lunny approved these changes 2023-08-05 10:09:33 +00:00
Owner

Let's see if it'll work.

Let's see if it'll work.
delvh merged commit d9f499f9e7 into main 2023-08-05 20:14:16 +00:00
denyskon deleted branch dynamic-release-image 2023-08-05 20:57:22 +00:00
Sign in to join this conversation.
No description provided.