Use gitea org as default author #233

jolheiser · 2023-01-25T05:40:57Z

jolheiser commented

2023-01-25 05:40:57 +00:00

No description provided.

jolheiser added 1 commit 2023-01-25 05:40:57 +00:00

fix: use gitea org as default author

Signed-off-by: jolheiser <john.olheiser@gmail.com>

continuous-integration/drone/pr Build is passing

Details

7b2ff8f67b

pat-s reviewed 2023-01-25 08:31:19 +00:00

pat-s left a comment

Or maybe something like "The Gitea maintainers" or "The Gitea core group"? Sounds a bit more "human" than just "Gitea".

jolheiser commented

2023-01-25 12:57:30 +00:00

Yes, but this value is currently used as a fallback for author in the string https://gitea.com/<author>

Yes, but this value is currently used as a fallback for author in the string `https://gitea.com/<author>`

jolheiser commented

2023-01-25 14:40:59 +00:00

Alternatively, I could open another PR against theme to not fallback, but rather use something else entirely.

The current problem, as I mentioned above, is that this value is only used in the concat string https://gitea.com/{{ .Params.author | default .Site.Params.author }}

One resolution is this PR, as it means it resolves to https://gitea.com/Gitea

An alternative could be that it does more explicit checking instead of using a default, such that {{ if not .Params.author }}...{{ end }} and we can instead put a more suitable default like you proposed.

Alternatively, I could open another PR against `theme` to not fallback, but rather use something else entirely. The current problem, as I mentioned above, is that this value is only used in the concat string `https://gitea.com/{{ .Params.author | default .Site.Params.author }}` One resolution is this PR, as it means it resolves to `https://gitea.com/Gitea` An alternative could be that it does more explicit checking instead of using a default, such that `{{ if not .Params.author }}...{{ end }}` and we can instead put a more suitable default like you proposed.

pat-s commented

2023-01-25 16:16:15 +00:00

This is just a Hugo think in the end, isn't it? It feels like there must be an "easy" solution to have "proper names" including whitespaces etc as the author with a smart logic for the respective URL insertion? ?

But for now - it should not block the current blog post.

This is just a Hugo think in the end, isn't it? It feels like there must be an "easy" solution to have "proper names" including whitespaces etc as the author with a smart logic for the respective URL insertion? ? But for now - it should not block the current blog post.

jolheiser commented

2023-01-25 16:37:02 +00:00

Yeah, it's all something we can control, just not sure how to get the best result without breaking past assumptions etc.

delvh approved these changes 2023-02-20 09:56:17 +00:00

lunny approved these changes 2023-02-20 11:28:24 +00:00

jolheiser merged commit bb4c24e031 into main

2023-02-20 15:20:52 +00:00

jolheiser referenced this issue from a commit

2023-02-20 15:20:52 +00:00

Use gitea org as default author (#233)

jolheiser deleted branch authors

2023-02-20 15:20:52 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/blog#233