gitea/blog
44
20
Fork 31
Code Issues 10 Pull Requests 2 Actions Activity

Hacking on Gitea Actions #246

Merged
wolfogre merged 18 commits from wolfogre/blog:feature/hacking-actions into main 2023-03-31 02:52:54 +00:00
Conversation 7 Commits 18 Files Changed 7 +455
wolfogre commented 2023-03-24 07:07:56 +00:00
Owner
Copy Link
No description provided.
wolfogre added 1 commit 2023-03-24 07:07:57 +00:00
feat: hacking actions
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7ee5be7665
wolfogre commented 2023-03-24 07:08:02 +00:00
Author
Owner
Copy Link

English is not my native language, feel free to correct any grammar or tone issues.

English is not my native language, feel free to correct any grammar or tone issues.
wolfogre commented 2023-03-24 07:19:42 +00:00
Author
Owner
Copy Link

It looks like there's something wrong with @website_pr_previewer_bot .

Here is preview page:

http://preview-gitea-org-blog-blog-246.s3-website.eu-central-1.amazonaws.com/2023/03/hacking-on-gitea-actions/

It looks like there's something wrong with @website_pr_previewer_bot . Here is preview page: http://preview-gitea-org-blog-blog-246.s3-website.eu-central-1.amazonaws.com/2023/03/hacking-on-gitea-actions/
wolfogre added 1 commit 2023-03-24 07:57:18 +00:00
fix: DEFAULT_ACTIONS_URL
All checks were successful
continuous-integration/drone/pr Build is passing
Details
17d41dc80b
wolfogre added 1 commit 2023-03-24 07:58:58 +00:00
fix: typo
All checks were successful
continuous-integration/drone/pr Build is passing
Details
577b3d977f
lunny approved these changes 2023-03-24 08:30:48 +00:00
pat-s commented 2023-03-24 08:34:08 +00:00
Member
Copy Link

@wolfogre I'll have a look soon WRT to the previewer bot. And I initially thought I did it as "unbreakable" as possible 😓

@wolfogre I'll have a look soon WRT to the previewer bot. And I initially thought I did it as "unbreakable" as possible 😓
😆 1
wolfogre added 1 commit 2023-03-24 09:01:03 +00:00
fix: typo
All checks were successful
continuous-integration/drone/pr Build is passing
Details
4cbe889498
wolfogre added 1 commit 2023-03-24 09:01:50 +00:00
fix: typo
All checks were successful
continuous-integration/drone/pr Build is passing
Details
6794424104
pat-s commented 2023-03-24 09:24:37 +00:00
Member
Copy Link

@wolfogre It looks to me the reason for the comment not to be appearing is that seconds after you opened the PR (and before the drone runner got to it) you posted a comment in the PR.

The CI step essentially looks whether there is already a comment in the PR and if so, skips adding one as it assumes to be the first comment.

So like in this case, if you're adding a comment faster than CI is doing it's first run (instead of editing the content of OP), the comment will not be posted.

@wolfogre It looks to me the reason for the comment not to be appearing is that seconds after you opened the PR (and before the drone runner got to it) you posted a comment in the PR. The CI step essentially looks whether there is already a comment in the PR and if so, skips adding one as it assumes to be the first comment. So like in this case, if you're adding a comment faster than CI is doing it's first run (instead of editing the content of OP), the comment will not be posted.
wolfogre added 1 commit 2023-03-24 09:49:44 +00:00
fix: adjust
All checks were successful
continuous-integration/drone/pr Build is passing
Details
f8cdfb45fc
wolfogre added 1 commit 2023-03-24 10:11:40 +00:00
fix: typo
All checks were successful
continuous-integration/drone/pr Build is passing
Details
2f3b6df2ce
wolfogre added 1 commit 2023-03-24 10:13:34 +00:00
fix: more
All checks were successful
continuous-integration/drone/pr Build is passing
Details
eaf3fbba10
wolfogre added 1 commit 2023-03-26 08:05:36 +00:00
fix: typo
All checks were successful
continuous-integration/drone/pr Build is passing
Details
294f653d6b
wolfogre added 1 commit 2023-03-29 10:34:06 +00:00
fix: demo without emojis
All checks were successful
continuous-integration/drone/pr Build is passing
Details
eb5ef492b9
lunny added 1 commit 2023-03-29 10:38:59 +00:00
Merge branch 'main' into feature/hacking-actions
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7b74926c43
silverwind approved these changes 2023-03-29 21:03:49 +00:00
silverwind left a comment
Member
Copy Link

Looks good to me generally.

I'd have one question: GitHub actions supports Mac OS and Windows runners too. Is that something that would be possible given a proper setup with the runner on those OS?

Looks good to me generally. I'd have one question: GitHub actions supports Mac OS and Windows runners too. Is that something that would be possible given a proper setup with the runner on those OS?
jolheiser requested changes 2023-03-29 21:10:13 +00:00
jolheiser left a comment
Owner
Copy Link

It would be nice to finalize changes in the pad before merging.

It would be nice to finalize changes in the pad before merging.
wolfogre added 5 commits 2023-03-30 03:45:02 +00:00
fix: owners
All checks were successful
continuous-integration/drone/pr Build is passing
Details
9f86dec2aa
wolfogre commented 2023-03-30 03:46:51 +00:00
Author
Owner
Copy Link

It would be nice to finalize changes in the pad before merging.

Done, but removed:

#### My runner has been set up but fails when cloning a repo inside a workflow

Did you register your instance as `localhost` on your runner?
If yes, please re-configure your runner to point at the IP or URL of your Gitea instance.

This has been mentioned above and explained later.

> It would be nice to finalize changes in the pad before merging. Done, but removed: ``` #### My runner has been set up but fails when cloning a repo inside a workflow Did you register your instance as `localhost` on your runner? If yes, please re-configure your runner to point at the IP or URL of your Gitea instance. ``` This has been mentioned above and explained later.
👍 1
delvh approved these changes 2023-03-30 16:06:15 +00:00
content/post/hacking-on-gitea-actions.md Outdated
@ -0,0 +1,439 @@
---
date: "2023-03-24T14:00:00+08:00"
delvh commented 2023-03-30 08:51:16 +00:00
Owner
Copy Link

2023-03-30

`2023-03-30`
👍 1
wolfogre marked this conversation as resolved
jolheiser approved these changes 2023-03-30 16:09:16 +00:00
jolheiser left a comment
Owner
Copy Link

lgtm (other than updating the date as delvh mentioned)

lgtm (other than updating the date as delvh mentioned)
👍 1
wolfogre added 1 commit 2023-03-31 01:44:36 +00:00
fix: date
All checks were successful
continuous-integration/drone/pr Build is passing
Details
e09d97025c
wolfogre added 1 commit 2023-03-31 02:16:13 +00:00
fix: operating systems
All checks were successful
continuous-integration/drone/pr Build is passing
Details
d8026f4ef9
wolfogre commented 2023-03-31 02:17:32 +00:00
Author
Owner
Copy Link

I'd have one question: GitHub actions supports Mac OS and Windows runners too. Is that something that would be possible given a proper setup with the runner on those OS?

@silverwind I added the question

d8026f4ef9

> I'd have one question: GitHub actions supports Mac OS and Windows runners too. Is that something that would be possible given a proper setup with the runner on those OS? @silverwind I added the question https://gitea.com/gitea/blog/commit/d8026f4ef90ca31d8e5e9ae9d2cec1476a3da76c
wolfogre merged commit 507eac598d into main 2023-03-31 02:52:54 +00:00
wolfogre commented 2023-03-31 03:15:56 +00:00
Author
Owner
Copy Link

Since I have no way of knowing who made the changes in the pad (I can't identify the users in the change history), please free to add yourself as author.

@silverwind
@delvh
@jolheiser

Since I have no way of knowing who made the changes in the pad (I can't identify the users in the change history), please free to add yourself as author. @silverwind @delvh @jolheiser
Sign in to join this conversation.
Reviewers
No reviewers
lunny
silverwind
delvh
jolheiser
Labels
Clear labels   
in progress

   
kind/bug

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
lgtm/done

   
lgtm/need 1

   
lgtm/need 2

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
status/blocked

   
status/needs-feedback

   
status/wip
No Label
in progress
kind/bug
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/security
kind/testing
kind/translation
kind/ui
lgtm/done
lgtm/need 1
lgtm/need 2
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
status/blocked
status/needs-feedback
status/wip
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/blog#246
No description provided.
Delete Branch "wolfogre/blog:feature/hacking-actions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?