gitea/blog
44
20
Fork 31
Code Issues 10 Pull Requests 2 Actions Activity

Delete PR s3 when PR closed #262

Merged
techknowlogick merged 4 commits from lunny/gitea-blog:lunny/delete_s3_pr_close into main 2023-04-20 14:48:28 +00:00
Conversation 3 Commits 4 Files Changed 1 +19
lunny commented 2023-04-20 08:33:43 +00:00
Owner
Copy Link
No description provided.
lunny added 1 commit 2023-04-20 08:33:44 +00:00
Delete PR s3 when PR closed
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 1m16s
Details
continuous-integration/drone/pr Build is passing
Details
cac5d7a703
website_pr_previewer_bot commented 2023-04-20 08:36:01 +00:00
First-time contributor
Copy Link

Website preview: http://preview-gitea-org-blog-blog-262.s3-website.eu-central-1.amazonaws.com/

Website preview: http://preview-gitea-org-blog-blog-262.s3-website.eu-central-1.amazonaws.com/
delvh approved these changes 2023-04-20 09:06:07 +00:00
delvh commented 2023-04-20 09:06:29 +00:00
Owner
Copy Link

Perhaps the @website_pr_previewer_bot should also delete his comment then?

Perhaps the @website_pr_previewer_bot should also delete his comment then?
pat-s commented 2023-04-20 11:29:54 +00:00
Member
Copy Link

Perhaps the @website_pr_previewer_bot should also delete his comment then?

Would be nice but quite some effort to implement for little gain only.

> Perhaps the @website_pr_previewer_bot should also delete his comment then? Would be nice but quite some effort to implement for little gain only.
techknowlogick added 1 commit 2023-04-20 14:38:58 +00:00
pass env vars
All checks were successful
continuous-integration/drone/pr Build is passing
Details
check-and-test / check-and-test (pull_request) Successful in 2m14s
Details
e9df42cf18
techknowlogick added 1 commit 2023-04-20 14:44:55 +00:00
rm files inside bucket too
All checks were successful
continuous-integration/drone/pr Build is passing
Details
check-and-test / check-and-test (pull_request) Successful in 1m31s
Details
eb96aa90ca
techknowlogick added 1 commit 2023-04-20 14:46:33 +00:00
-y
All checks were successful
continuous-integration/drone/pr Build is passing
Details
check-and-test / check-and-test (pull_request) Successful in 1m16s
Details
delete closed PR preview s3 / delete_preview (pull_request) Successful in 18s
Details
5affa936f8
techknowlogick approved these changes 2023-04-20 14:48:18 +00:00
techknowlogick merged commit d0a6708d0a into main 2023-04-20 14:48:28 +00:00
lunny deleted branch lunny/delete_s3_pr_close 2023-04-20 15:24:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
delvh
techknowlogick
Labels
Clear labels   
in progress

   
kind/bug

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
lgtm/done

   
lgtm/need 1

   
lgtm/need 2

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
status/blocked

   
status/needs-feedback

   
status/wip
No Label
in progress
kind/bug
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/security
kind/testing
kind/translation
kind/ui
lgtm/done
lgtm/need 1
lgtm/need 2
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
status/blocked
status/needs-feedback
status/wip
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/blog#262
No description provided.
Delete Branch "lunny/gitea-blog:lunny/delete_s3_pr_close"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?