gitea/blog
44
20
Fork 31
Code Issues 10 Pull Requests 3 Actions Activity

add breaking change to locale template function #320

Closed
danparisd wants to merge 1 commits from danparisd/blog:danparisd-locale-breaking into main
pull from: danparisd/blog:danparisd-locale-breaking
merge into: gitea:main
Conversation 2 Commits 1 Files Changed 1 +4
danparisd commented 2023-11-16 14:19:27 +00:00
First-time contributor
Copy Link

I ran into this and opened an issue. https://github.com/go-gitea/gitea/issues/28081

I ran into this and opened an issue. https://github.com/go-gitea/gitea/issues/28081
danparisd added 1 commit 2023-11-16 14:19:27 +00:00
add breaking change to locale template function
Some checks failed
delete closed PR preview s3 / delete_preview (pull_request) Successful in 19s
Details
check-and-test / check-and-test (pull_request) Has been cancelled
Details
6a2da59542
denyskon commented 2023-11-16 15:55:28 +00:00
Member
Copy Link

I don't think we should list it. Even though you are able to modify those files, it isn't a feature we advertise.

I don't think we should list it. Even though you are able to modify those files, it isn't a feature we advertise.
delvh commented 2023-11-16 15:59:38 +00:00
Owner
Copy Link

Exactly.
Template customization is an offer, not a guarantee.
As such, we don't report changes in them, otherwise they would be mentioned with every release.
If you customize your templates, you should minimize the changes to the existing templates to encounter less merge conflicts, i.e. by only adding new subtemplates.

Exactly. Template customization is an offer, not a guarantee. As such, we don't report changes in them, otherwise they would be mentioned with every release. If you customize your templates, you should minimize the changes to the existing templates to encounter less merge conflicts, i.e. by only adding new subtemplates.
delvh closed this pull request 2023-11-16 15:59:39 +00:00
Some checks failed
delete closed PR preview s3 / delete_preview (pull_request) Successful in 19s
Details
check-and-test / check-and-test (pull_request) Has been cancelled
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
in progress

   
kind/bug

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
lgtm/done

   
lgtm/need 1

   
lgtm/need 2

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
status/blocked

   
status/needs-feedback

   
status/wip
No Label
in progress
kind/bug
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/security
kind/testing
kind/translation
kind/ui
lgtm/done
lgtm/need 1
lgtm/need 2
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
status/blocked
status/needs-feedback
status/wip
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/blog#320
No description provided.
Delete Branch "danparisd/blog:danparisd-locale-breaking"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?