gitea/changelog
44
16
Fork 12
Code Issues 11 Pull Requests 2 Actions Releases 5 Wiki Activity

Update to urfave/cli/v3 #77

Merged
jolheiser merged 2 commits from jolheiser/changelog:flag into main 2023-04-03 03:51:25 +00:00
Conversation 2 Commits 2 Files Changed 6 +25 -44
jolheiser commented 2023-03-31 03:14:12 +00:00
Owner
Copy Link

This allows for persistent flags, such that changelog -m v0.4.0 generate and changelog generate -m v0.4.0 are equivalent.

As an aside, I dislike this kind of flag behavior, however our current flag parsing is broken because #54 actually caused the base flags to only work if they were called via subcommand due to how the library set the pointer values.

This allows for persistent flags, such that `changelog -m v0.4.0 generate` and `changelog generate -m v0.4.0` are equivalent. As an aside, I dislike this kind of flag behavior, however our current flag parsing is broken because #54 actually caused the base flags to only work if they were called via subcommand due to how the library set the pointer values.
❤️ 1
jolheiser added this to the v1.0.0 milestone 2023-03-31 03:14:12 +00:00
jolheiser added 1 commit 2023-03-31 03:14:13 +00:00
feat: update to urfave/cli/v3
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 1m46s
Details
ce9eabd1b6 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
jolheiser added 1 commit 2023-03-31 03:19:00 +00:00
chore: funlen isn't fun
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 1m46s
Details
7c385a751e 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
lunny commented 2023-03-31 03:22:13 +00:00
Owner
Copy Link

How about we convert to cobra

How about we convert to [cobra](https://github.com/spf13/cobra)
jolheiser commented 2023-03-31 03:23:01 +00:00
Author
Owner
Copy Link

If someone else wants to do so I will review, but I personally strongly dislike cobra.

If someone else wants to do so I will review, but I personally strongly dislike cobra.
👀 1 😆 2
6543 added the
bug
 label 2023-04-02 20:33:11 +00:00
6543 approved these changes 2023-04-02 20:34:01 +00:00
lunny approved these changes 2023-04-03 03:46:13 +00:00
jolheiser merged commit 8156d742f5 into main 2023-04-03 03:51:25 +00:00
jolheiser deleted branch flag 2023-04-03 03:51:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
6543
lunny
Labels
Clear labels   
breaking

   
bug

   
build

Changes to builds

  
duplicate

   
enhancement

   
feature

   
help wanted

   
invalid
  
lgtm
done

  
lgtm
need 1

  
question

   
skip-changelog

   
wontfix
No Label
breaking
bug
build
duplicate
enhancement
feature
help wanted
invalid
lgtm
done
lgtm
need 1
question
skip-changelog
wontfix
Milestone
Clear milestone
No items
No Milestone
v1.0.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/changelog#77
No description provided.
Delete Branch "jolheiser/changelog:flag"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?