Fix for bad commitID to show up in error #148

lunny · 2019-03-06T18:31:12Z

lunny commented

2019-03-06 18:31:12 +00:00

This error message for a bad commitID makes no sense because when the Error object is created, commitID is always empty since NewCommand() call replaced the given commitID. This makes sure we retain the old commitID until after this block.

Author: @richmahn This error message for a bad commitID makes no sense because when the Error object is created, commitID is always empty since NewCommand() call replaced the given commitID. This makes sure we retain the old commitID until after this block.

lunny commented

2019-03-06 18:32:50 +00:00

Author: @codecov-io

Codecov Report

Merging #148 into master will increase coverage by 0.41%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   36.07%   36.48%   +0.41%     
==========================================
  Files          28       28              
  Lines        1838     1839       +1     
==========================================
+ Hits          663      671       +8     
+ Misses       1085     1079       -6     
+ Partials       90       89       -1

Impacted Files	Coverage Δ
repo_commit.go	`28.67% <100%> (+2.84%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8983773...0c7c947. Read the comment docs.

Author: @codecov-io # [Codecov](https://codecov.io/gh/go-gitea/git/pull/148?src=pr&el=h1) Report > Merging [#148](https://codecov.io/gh/go-gitea/git/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/go-gitea/git/commit/8983773ac6fef49203e7ee8cdbfde3e118bc3421?src=pr&el=desc) will **increase** coverage by `0.41%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/go-gitea/git/pull/148/graphs/tree.svg?width=650&token=sCATTcwuUJ&height=150&src=pr)](https://codecov.io/gh/go-gitea/git/pull/148?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #148 +/- ## ========================================== + Coverage 36.07% 36.48% +0.41% ========================================== Files 28 28 Lines 1838 1839 +1 ========================================== + Hits 663 671 +8 + Misses 1085 1079 -6 + Partials 90 89 -1 ``` | [Impacted Files](https://codecov.io/gh/go-gitea/git/pull/148?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [repo\_commit.go](https://codecov.io/gh/go-gitea/git/pull/148/diff?src=pr&el=tree#diff-cmVwb19jb21taXQuZ28=) | `28.67% <100%> (+2.84%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-gitea/git/pull/148?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-gitea/git/pull/148?src=pr&el=footer). Last update [8983773...0c7c947](https://codecov.io/gh/go-gitea/git/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny commented

2019-03-08 07:46:16 +00:00

Author: @techknowlogick

Thanks for another PR @richmahn

Author: @techknowlogick Thanks for another PR @richmahn

lunny commented

2019-03-08 15:26:01 +00:00

Author: @richmahn

@techknowlogick Yes, will do that.

Author: @richmahn @techknowlogick Yes, will do that.

This repo is archived. You cannot comment on pull requests.

No reviewers