gitea/gitea-docusaurus
16
8
Fork 11
Code Issues 6 Pull Requests 1 Actions Releases Activity

Fix incorrect command order of prepare-docs #92

Merged
silverwind merged 4 commits from yp05327/gitea-docusaurus:fix-prepare-docs into main 2024-03-16 13:11:42 +00:00
Conversation 3 Commits 4 Files Changed 1 +1 -1
yp05327 commented 2023-11-27 01:57:36 +00:00
Contributor
Copy Link

The command order of prepare-docs is incorrect.
We should prepare same version with different locale at once, otherwise the doc files for zh-cn in i18n folder will be incorrect.

Before: (files in current is as same as version 1.19)
image

After:
image

The command order of prepare-docs is incorrect. We should prepare same version with different locale at once, otherwise the doc files for `zh-cn` in `i18n` folder will be incorrect. Before: (files in current is as same as version 1.19) ![image](/attachments/81a25d85-ec8e-45dc-b1a1-31d945ae3bfa) After: ![image](/attachments/31831db4-4f89-45a0-8685-5252665d747b)
image.png
77 KiB
image.png
28 KiB
yp05327 added 1 commit 2023-11-27 01:57:36 +00:00
fix prepare-docs
All checks were successful
checks / build-docs (pull_request) Successful in 6m28s
Details
e81e9deb56
lunny approved these changes 2023-11-28 04:30:09 +00:00
lunny added 1 commit 2023-11-28 04:30:17 +00:00
Merge branch 'main' into fix-prepare-docs
All checks were successful
checks / build-docs (pull_request) Successful in 6m31s
Details
bfd76ba778
yp05327 commented 2023-11-28 05:03:14 +00:00
Author
Contributor
Copy Link

Wait a minute.
Maybe the best way to fix this issue is add clone process in prepare-****-zh-cn command,
as the root reason of this issue is that in prepare-****-zh-cn we don't have clone process.
And it will cause this error:
image
Or we can check whether we already have cloned files in local?

@lunny @techknowlogick
What do you think about this?

Wait a minute. Maybe the best way to fix this issue is add clone process in `prepare-****-zh-cn` command, as the root reason of this issue is that in `prepare-****-zh-cn` we don't have clone process. And it will cause this error: ![image](/attachments/f9350975-cf82-42d6-8079-7058ebd3153d) Or we can check whether we already have cloned files in local? @lunny @techknowlogick What do you think about this?
image.png
22 KiB
denyskon commented 2023-11-28 05:05:27 +00:00
Member
Copy Link

Do we still have zh-cn docs? I thought we removed them...

Do we still have `zh-cn` docs? I thought we removed them...
lunny added 1 commit 2024-03-15 15:11:52 +00:00
Merge branch 'main' into fix-prepare-docs
Some checks failed
checks / build-docs (pull_request) Failing after 55s
Details
2c49f08e9e
lunny added 1 commit 2024-03-16 03:54:39 +00:00
Merge branch 'main' into fix-prepare-docs
All checks were successful
checks / build-docs (pull_request) Successful in 33m17s
Details
0daa90ae87
silverwind commented 2024-03-16 13:11:01 +00:00
Member
Copy Link

Do we still have zh-cn docs? I thought we removed them...

We have at least in the main repo. Agree to removing them.

> Do we still have `zh-cn` docs? I thought we removed them... We have at least in the main repo. Agree to removing them.
silverwind approved these changes 2024-03-16 13:11:23 +00:00
silverwind merged commit 90d5800117 into main 2024-03-16 13:11:42 +00:00
yp05327 requested review from lunny 2024-03-21 09:45:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
silverwind
lunny
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/gitea-docusaurus#92
No description provided.
Delete Branch "yp05327/gitea-docusaurus:fix-prepare-docs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?