gitea/gitea-vet
41
6
Fork 10
Code Issues 5 Pull Requests 1 Actions Releases 5 Activity

Add migration count check #27

Merged
lunny merged 2 commits from yp05327/gitea-vet:add-migration-count-check into main 2024-01-23 02:36:34 +00:00
Conversation 2 Commits 2 Files Changed 1 +30
yp05327 commented 2024-01-22 06:59:24 +00:00
Contributor
Copy Link

Add checks for no matching of migration functions count and the length of migrations defined in migrations.go

For example, for v284 -> v285
image
remove line 556:
image
run make lint-go-vet:
image

Add checks for no matching of migration functions count and the length of `migrations` defined in `migrations.go` For example, for `v284 -> v285` ![image](/attachments/e43c465e-d41f-4755-950d-d3565690ea2a) remove line 556: ![image](/attachments/a8598239-f123-415a-8090-3bdb781ce6ab) run `make lint-go-vet`: ![image](/attachments/7a55b7be-6c19-41b5-995f-98d4aa5a7100)
image.png
17 KiB
image.png
13 KiB
image.png
9.0 KiB
yp05327 added 2 commits 2024-01-22 06:59:24 +00:00
improve
All checks were successful
build and test / build and test (pull_request) Successful in 37s
Details
04aa321ccf
lunny commented 2024-01-22 09:58:17 +00:00
Owner
Copy Link

I don't think it's right. You need to count the files not the packages.

~~I don't think it's right. You need to count the files not the packages.~~
yp05327 commented 2024-01-22 23:55:01 +00:00
Author
Contributor
Copy Link

I don't think it's right. You need to count the files not the packages.

I don't understand. I count GoFiles in the packages.

> I don't think it's right. You need to count the files not the packages. I don't understand. I count `GoFiles` in the packages.
lunny approved these changes 2024-01-23 02:36:14 +00:00
lunny merged commit 621ce6ac7b into main 2024-01-23 02:36:34 +00:00
yp05327 deleted branch add-migration-count-check 2024-01-29 07:36:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lunny
Labels
Clear labels   
breaking

Introduce a breaking change

  
bug

Something is not working

  
build

Changes to builds

  
duplicate

This issue or pull request already exists

  
enhancement

An Imprufement

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
skip-changelog

   
wontfix

This won't be fixed

No Label
breaking
bug
build
duplicate
enhancement
feature
help wanted
invalid
question
skip-changelog
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/gitea-vet#27
No description provided.
Delete Branch "yp05327/gitea-vet:add-migration-count-check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?