added pagination options for listing requests #203

spawn2kill · 2019-12-20T12:14:30Z

spawn2kill commented

2019-12-20 12:14:30 +00:00

Like discussed on #202, all ListXXXXX requests now supports pagination.

ListXXXXXOptions structs which includes ListOptions struct have been added to all methods. By default it gets the first page with 10 results.

Gitea's API needs to be changed in order to support pagination in all requests.

Like discussed on [#202](https://gitea.com/gitea/go-sdk/pulls/202), all `ListXXXXX` requests now supports pagination. `ListXXXXXOptions` structs which includes `ListOptions` struct have been added to all methods. By default it gets the first page with 10 results. Gitea's API needs to be changed in order to support pagination in all requests.

lunny reviewed 2019-12-20 13:50:11 +00:00

Dismissed

gitea/admin_org.go Outdated

						
				@ -12,2 +12,4 @@

				)

				// AdminListOrgsOptions options for listing admin's organizations

				type AdminListOrgsOptions struct {

lunny commented

2019-12-20 13:50:11 +00:00

What's the difference between AdminListOrgsOptions and ListOrgsOptions?

What's the difference between `AdminListOrgsOptions` and `ListOrgsOptions`?

spawn2kill commented

2019-12-20 14:06:33 +00:00

I'm not sure what you are talking about... there isn't any struct called ListOrgsOptions. I just created an options struct for each request that lists something. About the AdminListOrgsOptions naming it's because it is sub route from /admin: https://try.gitea.io/api/swagger#/admin/adminGetAllOrgs

I'm not sure what you are talking about... there isn't any struct called `ListOrgsOptions`. I just created an options struct for each request that lists something. About the **Admin**ListOrgsOptions naming it's because it is sub route from `/admin`: https://try.gitea.io/api/swagger#/admin/adminGetAllOrgs