gitea/go-sdk
44
46
Fork 72
Code Issues 21 Pull Requests 7 Actions Releases 19 Activity

Use Predefind Versions & Compare Function #442

Merged
zeripath merged 11 commits from 6543/go-sdk:bugfix_440_usePredefind-ConstrainChecks into master 2020-11-12 20:59:05 +00:00
Conversation 1 Commits 11 Files Changed 22 +83 -50
6543 commented 2020-11-08 23:23:28 +00:00
Owner
Copy Link

close #440 and speedup this lib

close #440 and speedup this lib
6543 added this to the v0.14.0 milestone 2020-11-08 23:23:28 +00:00
6543 added the
kind/bug
need/backport
 labels 2020-11-08 23:23:28 +00:00
6543 force-pushed bugfix_440_usePredefind-ConstrainChecks from 39b2538167 to a58f932127 2020-11-09 00:54:23 +00:00 Compare
6543 added the
status/needs-reviews
 label 2020-11-09 00:54:43 +00:00
lunny reviewed 2020-11-09 01:01:16 +00:00
Dismissed
gitea/version.go
@ -45,0 +53,4 @@
func (c *Client) checkServerVersionGreaterThanOrEqual(v *version.Version) error {
c.versionLock.RLock()
if c.serverVersion == nil {
c.versionLock.RUnlock()
lunny commented 2020-11-09 01:01:16 +00:00
Owner
Copy Link

Is this really locked?

Is this really locked?
6543 commented 2020-11-09 01:07:35 +00:00
Author
Owner
Copy Link

yes (from two lines above)

yes (from two lines above)
lunny commented 2020-11-13 00:44:46 +00:00
Owner
Copy Link

#456

https://gitea.com/gitea/go-sdk/pulls/456
lunny marked this conversation as resolved
6543 added
has/backport
 and removed
need/backport
 labels 2020-11-09 01:06:07 +00:00
6543 commented 2020-11-09 01:06:19 +00:00
Author
Owner
Copy Link

Backport: #446

Backport: #446
6543 added 1 commit 2020-11-09 01:09:24 +00:00
Merge branch 'master' into bugfix_440_usePredefind-ConstrainChecks
Some checks failed
continuous-integration/drone/pr Build is failing
Details
61b14fbedd
6543 added 1 commit 2020-11-09 01:14:39 +00:00
update test data
All checks were successful
continuous-integration/drone/pr Build is passing
Details
eb8e2b2c97
noerw approved these changes 2020-11-09 15:41:06 +00:00
Dismissed
noerw left a comment
Member
Copy Link

Can we have _ separators in the version constants to reduce ambiguity?
Otherwise lgtm

Can we have `_` separators in the version constants to reduce ambiguity? Otherwise lgtm
6543 removed the
status/needs-reviews
 label 2020-11-09 16:21:42 +00:00
6543 added 1 commit 2020-11-09 16:24:40 +00:00
version use underscore
All checks were successful
continuous-integration/drone/pr Build is passing
Details
f55758ce8b
6543 added 1 commit 2020-11-09 16:25:35 +00:00
version use underscore
All checks were successful
continuous-integration/drone/pr Build is passing
Details
df7f5c7845
6543 requested review from lunny 2020-11-09 17:19:38 +00:00
6543 added 1 commit 2020-11-09 20:55:29 +00:00
Merge branch 'master' into bugfix_440_usePredefind-ConstrainChecks
Some checks failed
continuous-integration/drone/pr Build is failing
Details
6e151fba82
6543 added 1 commit 2020-11-09 21:19:26 +00:00
Update TestData
All checks were successful
continuous-integration/drone/pr Build is passing
Details
964dee2260
zeripath approved these changes 2020-11-12 20:58:30 +00:00
Dismissed
zeripath merged commit 9c81fa936f into master 2020-11-12 20:59:04 +00:00
6543 deleted branch bugfix_440_usePredefind-ConstrainChecks 2020-11-12 20:59:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has/backport

   
has/pull

   
in progress

   
invalid

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
need/backport

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
Milestone
Clear milestone
No items
No Milestone
v0.14.0
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#442
No description provided.
Delete Branch "6543/go-sdk:bugfix_440_usePredefind-ConstrainChecks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?