Use Predefind Versions & Compare Function #442

Merged
zeripath merged 11 commits from 6543/go-sdk:bugfix_440_usePredefind-ConstrainChecks into master 12 months ago
6543 commented 12 months ago
Collaborator

close #440 and speedup this lib

close #440 and speedup this lib
6543 added this to the v0.14.0 milestone 12 months ago
6543 added the
kind/bug
need/backport
labels 12 months ago
6543 force-pushed bugfix_440_usePredefind-ConstrainChecks from 39b2538167 to a58f932127 12 months ago
6543 added the
status/needs-reviews
label 12 months ago
lunny reviewed 12 months ago
Dismissed
func (c *Client) checkServerVersionGreaterThanOrEqual(v *version.Version) error {
c.versionLock.RLock()
if c.serverVersion == nil {
c.versionLock.RUnlock()
Poster
Owner

Is this really locked?

Is this really locked?
6543 commented 12 months ago
Poster
Collaborator

yes (from two lines above)

yes (from two lines above)
Poster
Owner
https://gitea.com/gitea/go-sdk/pulls/456
lunny marked this conversation as resolved
6543 added
has/backport
and removed
need/backport
labels 12 months ago
Poster
Collaborator

Backport: #446

Backport: #446
6543 added 1 commit 12 months ago
6543 added 1 commit 12 months ago
eb8e2b2c97
update test data
noerw approved these changes 12 months ago
Dismissed
noerw left a comment

Can we have _ separators in the version constants to reduce ambiguity?
Otherwise lgtm

6543 removed the
status/needs-reviews
label 12 months ago
6543 added 1 commit 12 months ago
f55758ce8b
version use underscore
6543 added 1 commit 12 months ago
df7f5c7845
version use underscore
6543 requested review from lunny 12 months ago
6543 added 1 commit 12 months ago
6543 added 1 commit 12 months ago
964dee2260
Update TestData
zeripath approved these changes 12 months ago
Dismissed
zeripath merged commit 9c81fa936f into master 12 months ago
6543 deleted branch bugfix_440_usePredefind-ConstrainChecks 12 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 9c81fa936f.
Sign in to join this conversation.
Loading…
There is no content yet.