Fix ListIssue Functions (now respect ListIssueOption's) #225
No reviewers
Labels
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitea/go-sdk#225
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "6543/go-sdk:fix-some-stuff"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
as title
@ -1,3 +1,4 @@
// Copyright 2020 The Gitea Authors. All rights reserved.
The line should below gogs'
@ -15,3 +15,2 @@
func (c *Client) AdminListUsers() ([]*User, error) {
users := make([]*User, 0, 10)
return users, c.getParsedResponse("GET", "/admin/users", nil, nil, &users)
users := make([]*User, 0, 50)
How about break the method?
what do you mean ?
@lunny ⬆️
I mean we could change the method signature.
I would move this to #205 ?
Update Dates; Fix /admin/users; Fix ListIssueOptionto Update Dates; Fix ListIssueOption@lunny I removed the questionable AdminListUsers pagination loop change
-> so paggination now shold be done compleatly in #205 ...
Update Dates; Fix ListIssueOptionto Fix ListIssue Functions (now respect ListIssueOption's)@ -58,3 +96,2 @@
func (c *Client) ListUserIssues(opt ListIssueOption) ([]*Issue, error) {
issues := make([]*Issue, 0, 10)
return issues, c.getParsedResponse("GET", fmt.Sprintf("/user/issues?page=%d", opt.Page), nil, nil, &issues)
//issues := make([]*Issue, 0, 10)
Why comment this but not just left it there?
I'll make a workaround witch let this function work ...
So it's blocked by another PR?
no, the endpint simply ont exist
4ea32995e4
(@bkcsoft) added this butCould you add some tests?
@lunny added Tests and format test output:
ready to merge 🚀