gitea/go-sdk
44
46
Fork 73
Code Issues 21 Pull Requests 7 Actions Releases 19 Activity

Pull : Add a Fallback for GetPullRequestDiff/Patch #399

Merged
techknowlogick merged 7 commits from 6543/go-sdk:pull_get-diff-patch_add-fallback into master 2020-09-07 03:18:28 +00:00
Conversation 2 Commits 7 Files Changed 3 +38 -2
6543 commented 2020-09-04 19:56:11 +00:00
Owner
Copy Link

follow up of #398

and add TESTs

follow up of #398 and add TESTs
6543 added this to the v0.13.0 milestone 2020-09-04 19:56:11 +00:00
6543 added the
kind/enhancement
 label 2020-09-04 19:56:11 +00:00
6543 added 2 commits 2020-09-04 19:56:17 +00:00
Add Tests
All checks were successful
continuous-integration/drone/pr Build is passing
Details
48cfcab96f
6543 reviewed 2020-09-04 20:03:35 +00:00
Dismissed
gitea/pull_test.go
@ -59,0 +61,4 @@
assert.Len(t, diff, 1310)
patch, err := c.GetPullRequestPatch(c.username, repoName, pullUpdateFile.Index)
assert.NoError(t, err)
assert.True(t, len(patch) > len(diff))
6543 commented 2020-09-04 20:03:35 +00:00
Author
Owner
Copy Link

INFO: since patch contain time infos (witch change each test) i cant check for exact lenth

INFO: since patch contain time infos (witch change each test) i cant check for exact lenth
abayer commented 2020-09-04 20:06:25 +00:00
Contributor
Copy Link

I legitimately wasn't sure how to write tests for this, so I promise if I've got more to contribute in the future, there will be tests. =)

I legitimately wasn't sure how to write tests for this, so I promise if I've got more to contribute in the future, there will be tests. =)
🎉 1
6543 added 1 commit 2020-09-04 20:06:44 +00:00
fix misspell
All checks were successful
continuous-integration/drone/pr Build is passing
Details
5a40a0c60c
abayer reviewed 2020-09-04 20:06:59 +00:00
Dismissed
gitea/pull.go
@ -222,2 +222,4 @@
}
// getPullRequestDiffOrPatch gets the patch or diff file as bytes for a PR
func (c *Client) getPullRequestDiffOrPatch(owner, repo, kind string, index int64) ([]byte, error) {
abayer commented 2020-09-04 20:06:59 +00:00
Contributor
Copy Link

Probably should be getPullRequestDiffOrPatch? =)

Probably should be `getPullRequestDiffOrPatch`? =)
6543 commented 2020-09-04 20:09:37 +00:00
Author
Owner
Copy Link

@abayer good first catch :)

@abayer good first catch :)
6543 marked this conversation as resolved
techknowlogick reviewed 2020-09-04 20:07:18 +00:00
Dismissed
gitea/client.go
@ -75,2 +75,4 @@
}
func (c *Client) getWebResponse(method, path string, body io.Reader) ([]byte, error) {
req, err := http.NewRequest(method, c.url+path, body)
techknowlogick commented 2020-09-04 20:07:18 +00:00
Owner
Copy Link

should auth be included in this request?

should auth be included in this request?
6543 commented 2020-09-04 20:08:15 +00:00
Author
Owner
Copy Link

it would not work ... that's why https://github.com/go-gitea/gitea/pull/11751 was created

it would not work ... that's why https://github.com/go-gitea/gitea/pull/11751 was created
6543 commented 2020-09-04 20:08:47 +00:00
Author
Owner
Copy Link

so fallback only works by using the existing web endpoint wo do not need auth

so fallback only works by using the existing web endpoint wo do not need auth
techknowlogick marked this conversation as resolved
6543 commented 2020-09-04 20:20:13 +00:00
Author
Owner
Copy Link

@abayer if you are on linux

make test-instance create the test instance you can test against with make test

@abayer if you are on linux `make test-instance` create the test instance you can test against with `make test`
6543 added the
status/needs-reviews
 label 2020-09-04 22:42:03 +00:00
zeripath approved these changes 2020-09-05 06:21:04 +00:00
Dismissed
6543 added 1 commit 2020-09-06 13:48:28 +00:00
CI.restart()
All checks were successful
continuous-integration/drone/pr Build is passing
Details
11a04460a2
6543 added 1 commit 2020-09-06 17:34:18 +00:00
Merge branch 'master' into pull_get-diff-patch_add-fallback
All checks were successful
continuous-integration/drone/pr Build is passing
Details
9177c79860
techknowlogick approved these changes 2020-09-07 03:10:50 +00:00
Dismissed
techknowlogick removed the
status/needs-reviews
 label 2020-09-07 03:11:02 +00:00
techknowlogick added 1 commit 2020-09-07 03:11:49 +00:00
Merge branch 'master' into pull_get-diff-patch_add-fallback
All checks were successful
continuous-integration/drone/pr Build is passing
Details
a1042ff208
techknowlogick merged commit 18f39029e9 into master 2020-09-07 03:18:00 +00:00
6543 deleted branch pull_get-diff-patch_add-fallback 2020-09-07 04:04:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has/backport

   
has/pull

   
in progress

   
invalid

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
need/backport

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
Milestone
Clear milestone
No items
No Milestone
v0.13.0
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#399
No description provided.
Delete Branch "6543/go-sdk:pull_get-diff-patch_add-fallback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?