Add DeleteTag & Correct DeleteReleaseByTag #488

Merged
6543 merged 1 commits from 6543/go-sdk:fix-delete-release-and-delete-tag-func into master 9 months ago
6543 commented 9 months ago
Collaborator
  • Add DeleteTag + Tests
  • Correct DeleteReleaseByTag func + Tests

this is because of https://github.com/go-gitea/gitea/pull/14563 witch fixed unreleased inconsistency

* Add DeleteTag + Tests * Correct DeleteReleaseByTag func + Tests this is because of https://github.com/go-gitea/gitea/pull/14563 witch fixed unreleased inconsistency
6543 added 1 commit 9 months ago
6543 changed title from Add DeleteTag + Tests && Correct DeleteReleaseByTag func + Tests to Add DeleteTag & Correct DeleteReleaseByTag 9 months ago
6543 added this to the v0.14.0 milestone 9 months ago
6543 added the
kind/enhancement
label 9 months ago
zeripath reviewed 9 months ago
Dismissed
// DeleteReleaseTag deletes a tag from a repository, if no release refers to it.
func (c *Client) DeleteReleaseTag(user, repo string, tag string) (*Response, error) {
// DeleteReleaseByTag deletes a release frm a repository by tag
func (c *Client) DeleteReleaseByTag(user, repo string, tag string) (*Response, error) {
Poster
Collaborator

This is an API change for downstream users. Is this intentional?

This is an API change for downstream users. Is this intentional?
Poster
Collaborator

You probably need to have a func (c *Client) DeleteReleaseTag(...) function which immediately calls on to c.DeleteReleaseByTag(...).

You probably need to have a `func (c *Client) DeleteReleaseTag(...)` function which immediately calls on to `c.DeleteReleaseByTag(...)`.
6543 commented 9 months ago
Poster
Collaborator

(was not released jet so no breaking thing) ;)

(was not released jet so no breaking thing) ;)
6543 marked this conversation as resolved
zeripath approved these changes 9 months ago
Dismissed
khmarbaise approved these changes 9 months ago
Dismissed
6543 merged commit c5a981333c into master 9 months ago
6543 deleted branch fix-delete-release-and-delete-tag-func 9 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as c5a981333c.
Sign in to join this conversation.
Loading…
There is no content yet.