Add DeleteTag & Correct DeleteReleaseByTag #488

Merged
6543 merged 1 commits from 6543/go-sdk:fix-delete-release-and-delete-tag-func into master 2021-02-13 16:14:24 +00:00
Owner
  • Add DeleteTag + Tests
  • Correct DeleteReleaseByTag func + Tests

this is because of https://github.com/go-gitea/gitea/pull/14563 witch fixed unreleased inconsistency

* Add DeleteTag + Tests * Correct DeleteReleaseByTag func + Tests this is because of https://github.com/go-gitea/gitea/pull/14563 witch fixed unreleased inconsistency
6543 added 1 commit 2021-02-13 05:17:17 +00:00
Add DeleteTag + Tests && Correct DeleteReleaseByTag func + Tests
All checks were successful
continuous-integration/drone/pr Build is passing
98e42e22ba
6543 changed title from Add DeleteTag + Tests && Correct DeleteReleaseByTag func + Tests to Add DeleteTag & Correct DeleteReleaseByTag 2021-02-13 05:17:35 +00:00
6543 added this to the v0.14.0 milestone 2021-02-13 05:17:40 +00:00
6543 added the
kind/enhancement
label 2021-02-13 05:17:47 +00:00
zeripath reviewed 2021-02-13 15:10:57 +00:00
Dismissed
@ -136,2 +136,2 @@
// DeleteReleaseTag deletes a tag from a repository, if no release refers to it.
func (c *Client) DeleteReleaseTag(user, repo string, tag string) (*Response, error) {
// DeleteReleaseByTag deletes a release frm a repository by tag
func (c *Client) DeleteReleaseByTag(user, repo string, tag string) (*Response, error) {
Owner

This is an API change for downstream users. Is this intentional?

This is an API change for downstream users. Is this intentional?
Owner

You probably need to have a func (c *Client) DeleteReleaseTag(...) function which immediately calls on to c.DeleteReleaseByTag(...).

You probably need to have a `func (c *Client) DeleteReleaseTag(...)` function which immediately calls on to `c.DeleteReleaseByTag(...)`.
Author
Owner

(was not released jet so no breaking thing) ;)

(was not released jet so no breaking thing) ;)
6543 marked this conversation as resolved
zeripath approved these changes 2021-02-13 15:15:04 +00:00
Dismissed
khmarbaise approved these changes 2021-02-13 16:06:35 +00:00
Dismissed
6543 merged commit c5a981333c into master 2021-02-13 16:14:24 +00:00
6543 deleted branch fix-delete-release-and-delete-tag-func 2021-02-13 16:14:30 +00:00
Sign in to join this conversation.
No description provided.