Drop deprecations #503

I think it's too early to drop support for gitea 1.11 we want to make it possible for people to use this library to migrate from earlier, potentially abandoned giteas.

6543 commented

2021-03-23 10:44:20 +00:00

gitea >= 1.12.0 add paggination support ... - if you at the moment use the sdk in pagination mode it's very easy to get infinety loops with old versions
a nice edge case example:
A: say newer gitea paginate with 50 items
but you have a old non-paginating gitea with 50 issues ...
you can not detect by if (len(item) < maxitem { break } else { next page }

if you have more than max items ... you can at least detect pagination is not working

ref #473

gitea >= 1.12.0 add paggination support ... - if you at the moment use the sdk in pagination mode it's very easy to get infinety loops with old versions a nice edge case example: A: say newer gitea paginate with 50 items but you have a old non-paginating gitea with 50 issues ... you can not detect by `if (len(item) < maxitem { break } else { next page }` if you have more than max items ... you can at least detect pagination is not working ref #473

lunny commented

2021-03-23 11:15:31 +00:00

Asignee could be the first Asignees

6543 commented

2021-03-23 11:54:18 +00:00

Asignee could be the first Asignees

Is there a different between all asignees and the first one for an issue/pull?

> Asignee could be the first Asignees Is there a different between all asignees and the first one for an issue/pull?

6543 added a new dependency 2021-03-23 19:33:21 +00:00

#473 [WIP] Add Next() pagination helper to Response

6543 commented

2021-03-29 17:54:49 +00:00

I have an idear how to avoid droping v1.11 support ... but get #473 let le have a look

6543 added the

status/wip

label 2021-03-29 17:54:56 +00:00

6543 force-pushed start-0.15.0-dev from 3df7fcec02 to 14379d1d2a

2021-03-29 23:03:36 +00:00

Compare

6543 changed title from ~~Drop deprecations & gitea <1.12.3 support~~ to Drop deprecations

2021-03-29 23:04:13 +00:00

6543 removed the

status/wip

label 2021-03-29 23:04:22 +00:00

6543 commented

2021-03-29 23:05:59 +00:00

@zeripath I did left v1.11 support ...

@lunny the one field we drop finaly do not have any real value ... it's just because github had this in the past so it will stay in the api but the sdk do not have to support it since there is a clear migration path

@zeripath I did left v1.11 support ... @lunny the one field we drop finaly do not have any real value ... it's just because github had this in the past so it will stay in the api but the sdk do not have to support it since there is a clear migration path

6543 removed a dependency 2021-03-29 23:20:03 +00:00

#473 [WIP] Add Next() pagination helper to Response

6543 added 1 commit 2021-03-29 23:22:36 +00:00

CI: test with go-v1.16

continuous-integration/drone/pr Build is passing

Details

f5e23847e8

6543 requested review from noerw 2021-03-29 23:23:40 +00:00

lunny approved these changes 2021-03-30 11:14:28 +00:00

Dismissed

noerw approved these changes 2021-03-30 12:02:34 +00:00

Dismissed