Drop deprecations #503

Merged
6543 merged 2 commits from 6543/go-sdk:start-0.15.0-dev into master 1 year ago
6543 commented 1 year ago
Collaborator

start v0.15.0 development

start v0.15.0 development
6543 added this to the v0.15.0 milestone 1 year ago
6543 added the
kind/breaking
label 1 year ago
6543 added 2 commits 1 year ago
noerw approved these changes 1 year ago
Dismissed
Collaborator

For a better changelog, maybe rename the PR to drop deprecations & gitea <1.12.3 support?

For a better changelog, maybe rename the PR to `drop deprecations & gitea <1.12.3 support`?
6543 changed title from Start v0.15.0 Development to Drop deprecations & gitea <1.12.3 support 1 year ago
6543 added 1 commit 1 year ago
3df7fcec02 Merge branch 'master' into start-0.15.0-dev
Owner

I think it's too early to drop support for gitea 1.11 we want to make it possible for people to use this library to migrate from earlier, potentially abandoned giteas.

I think it's too early to drop support for gitea 1.11 we want to make it possible for people to use this library to migrate from earlier, potentially abandoned giteas.
Poster
Collaborator

gitea >= 1.12.0 add paggination support ... - if you at the moment use the sdk in pagination mode it's very easy to get infinety loops with old versions
a nice edge case example:
A: say newer gitea paginate with 50 items
but you have a old non-paginating gitea with 50 issues ...
you can not detect by if (len(item) < maxitem { break } else { next page }

if you have more than max items ... you can at least detect pagination is not working

ref #473

gitea >= 1.12.0 add paggination support ... - if you at the moment use the sdk in pagination mode it's very easy to get infinety loops with old versions a nice edge case example: A: say newer gitea paginate with 50 items but you have a old non-paginating gitea with 50 issues ... you can not detect by `if (len(item) < maxitem { break } else { next page }` if you have more than max items ... you can at least detect pagination is not working ref #473
Owner

Asignee could be the first Asignees

Asignee could be the first Asignees
Poster
Collaborator

Asignee could be the first Asignees

Is there a different between all asignees and the first one for an issue/pull?

> Asignee could be the first Asignees Is there a different between all asignees and the first one for an issue/pull?
Poster
Collaborator

I have an idear how to avoid droping v1.11 support ... but get #473 let le have a look

I have an idear how to avoid droping v1.11 support ... but get #473 let le have a look
6543 added the
status/wip
label 1 year ago
6543 force-pushed start-0.15.0-dev from 3df7fcec02 to 14379d1d2a 1 year ago
6543 changed title from Drop deprecations & gitea <1.12.3 support to Drop deprecations 1 year ago
6543 removed the
status/wip
label 1 year ago
Poster
Collaborator

@zeripath I did left v1.11 support ...

@lunny the one field we drop finaly do not have any real value ... it's just because github had this in the past so it will stay in the api but the sdk do not have to support it since there is a clear migration path

@zeripath I did left v1.11 support ... @lunny the one field we drop finaly do not have any real value ... it's just because github had this in the past so it will stay in the api but the sdk do not have to support it since there is a clear migration path
6543 added 1 commit 1 year ago
f5e23847e8
CI: test with go-v1.16
6543 requested review from noerw 1 year ago
lunny approved these changes 1 year ago
Dismissed
noerw approved these changes 1 year ago
Dismissed
6543 merged commit 0599915e88 into master 1 year ago
6543 referenced this issue from a commit 1 year ago
6543 deleted branch start-0.15.0-dev 1 year ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 0599915e88.
Sign in to join this conversation.
Loading…
There is no content yet.