gitea/go-sdk
45
48
Fork 76
Code Issues 24 Pull Requests 11 Actions Releases 20 Activity

GetPullRequestDiff: add PullRequestDiffOptions param #542

Merged
6543 merged 9 commits from noerw/go-sdk:add-binary-diff-opt into master 2022-01-13 17:30:39 +00:00
Conversation 2 Commits 9 Files Changed 4 +55 -11
noerw commented 2021-09-28 08:48:07 +00:00
Member
Copy Link

this is for the upstream change in https://github.com/go-gitea/gitea/pull/17158

this is for the upstream change in https://github.com/go-gitea/gitea/pull/17158
noerw added this to the v0.16.0 milestone 2021-09-28 08:48:07 +00:00
noerw added the
kind/breaking
kind/enhancement
 labels 2021-09-28 08:48:07 +00:00
noerw added 1 commit 2021-09-28 08:48:08 +00:00
GetPullRequestDiff: expose binary param
Some checks failed
continuous-integration/drone/pr Build is failing
Details
196bca538a 
added in https://github.com/go-gitea/gitea/pull/17158
noerw added 1 commit 2021-09-28 15:44:49 +00:00
update tests
All checks were successful
continuous-integration/drone/pr Build is passing
Details
6c96bb4218
lunny commented 2021-09-30 02:11:13 +00:00
Owner
Copy Link

But we may have more options in future?

But we may have more options in future?
noerw added 1 commit 2021-10-12 06:55:23 +00:00
Merge branch 'master' into add-binary-diff-opt
All checks were successful
continuous-integration/drone/pr Build is passing
Details
c8f8179c85
6543 reviewed 2022-01-04 17:11:34 +00:00
gitea/pull.go Outdated
@ -284,2 +283,2 @@
func (c *Client) GetPullRequestDiff(owner, repo string, index int64) ([]byte, *Response, error) {
return c.getPullRequestDiffOrPatch(owner, repo, "diff", index)
// GetPullRequestDiff gets the diff of a PR. For Gitea >= 1.16, you must set includeBinary to get an applicable diff
func (c *Client) GetPullRequestDiff(owner, repo string, index int64, includeBinary bool) ([]byte, *Response, error) {
6543 commented 2022-01-04 17:11:33 +00:00
Owner
Copy Link

breaking changes must be documented in migration howto

breaking changes must be documented in migration howto
noerw marked this conversation as resolved
noerw added 1 commit 2022-01-11 10:47:27 +00:00
Merge branch 'master' into add-binary-diff-opt
All checks were successful
continuous-integration/drone/pr Build is passing
Details
9b8b3cf4d4
noerw added 3 commits 2022-01-11 11:16:29 +00:00
add migration documentation
Some checks failed
continuous-integration/drone/pr Build is failing
Details
1739289e65
noerw added 1 commit 2022-01-11 11:19:29 +00:00
update test
Some checks failed
continuous-integration/drone/pr Build is failing
Details
904ee976e3
noerw changed title from GetPullRequestDiff: add includeBinary option to GetPullRequestDiff: add PullRequestDiffOptios param 2022-01-11 11:22:32 +00:00
noerw commented 2022-01-11 11:23:27 +00:00
Author
Member
Copy Link

@6543 @lunny please rereview :)

@6543 @lunny please rereview :)
👍 1
noerw added 1 commit 2022-01-11 11:24:46 +00:00
lint
All checks were successful
continuous-integration/drone/pr Build is passing
Details
1653c52cb6
noerw changed title from GetPullRequestDiff: add PullRequestDiffOptios param to GetPullRequestDiff: add PullRequestDiffOptions param 2022-01-11 11:31:23 +00:00
6543 reviewed 2022-01-11 23:49:18 +00:00
gitea/pull.go Outdated
@ -267,0 +267,4 @@
// PullRequestDiffOptions options for GET /repos/<owner>/<repo>/pulls/<idx>.[diff|patch]
type PullRequestDiffOptions struct {
// Include binary file changes when requesting a .diff
Binary bool
6543 commented 2022-01-11 23:49:18 +00:00
Owner
Copy Link

since this is optional and upstream default is true - we should change it to *bool type

since this is optional and upstream default is true - we should change it to `*bool` type
noerw commented 2022-01-12 18:40:44 +00:00
Author
Member
Copy Link

No, upstream default is false.

No, upstream default is false.
6543 marked this conversation as resolved
lunny approved these changes 2022-01-13 06:25:19 +00:00
6543 approved these changes 2022-01-13 17:30:31 +00:00
6543 merged commit 3ff2c60a86 into master 2022-01-13 17:30:39 +00:00
noerw deleted branch add-binary-diff-opt 2022-01-14 10:42:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lunny
6543
Labels
Clear labels   
has/backport

   
has/pull

   
in progress

   
invalid

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
need/backport

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
Milestone
Clear milestone
No items
No Milestone
v0.16.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#542
No description provided.
Delete Branch "noerw/go-sdk:add-binary-diff-opt"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?