gitea/go-sdk
44
46
Fork 73
Code Issues 21 Pull Requests 6 Actions Releases 19 Activity

GetPullRequestDiff: add PullRequestDiffOptions param #542

Merged
6543 merged 9 commits from noerw/go-sdk:add-binary-diff-opt into master 2022-01-13 17:30:39 +00:00
Conversation 2 Commits 9 Files Changed 4 +1
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 1653c52cb6 - Show all commits

1
gitea/pull.go
View File

@ -270,6 +270,7 @@ type PullRequestDiffOptions struct {
Binary bool
6543 marked this conversation as resolved
6543 commented 2022-01-11 23:49:18 +00:00
Review
Copy Link

since this is optional and upstream default is true - we should change it to *bool type

since this is optional and upstream default is true - we should change it to `*bool` type
noerw commented 2022-01-12 18:40:44 +00:00
Review
Copy Link

No, upstream default is false.

No, upstream default is false.
}
// QueryEncode converts the options to a query string
func (o PullRequestDiffOptions) QueryEncode() string {
query := make(url.Values)
query.Add("binary", fmt.Sprintf("%v", o.Binary))