gitea/go-sdk
46
47
Fork 73
Code Issues 21 Pull Requests 6 Actions Releases 19 Activity

Allow PR review with comments only #570

Merged
jolheiser merged 2 commits from arkamar/go-sdk:allow-comments-only-review into master 2022-05-01 19:09:35 +00:00
Conversation 3 Commits 2 Files Changed 1 +1 -1
arkamar commented 2022-02-17 08:40:49 +00:00
Contributor
Copy Link

It is common to create PR review with Comments only, where foreword Body is empty. This is allowed by Gitea API, therefore SDK should return empty body error only if there are no comments.

It is common to create PR review with Comments only, where foreword Body is empty. This is allowed by Gitea API, therefore SDK should return empty body error only if there are no comments.
arkamar added 1 commit 2022-02-17 08:40:50 +00:00
Allow PR review with comments only
Some checks failed
continuous-integration/drone/pr Build is failing
Details
c8c15277ab 
It is common to create PR review with Comments only, where foreword Body
is empty. This is allowed by Gitea API, therefore SDK should return
empty body error only if there are no comments.

Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
noerw approved these changes 2022-03-08 22:18:20 +00:00
lunny commented 2022-03-09 02:38:31 +00:00
Owner
Copy Link

So then reject a pull request with no comment is impossible?

So then reject a pull request with no comment is impossible?
👀 1
zeripath approved these changes 2022-03-28 23:26:44 +00:00
jolheiser commented 2022-04-29 21:58:12 +00:00
Owner
Copy Link

Could you update your branch? After that CI should be able to run. ?

Could you update your branch? After that CI should be able to run. ?
lunny added 1 commit 2022-04-30 16:21:15 +00:00
Merge branch 'master' into allow-comments-only-review
All checks were successful
continuous-integration/drone/pr Build is passing
Details
fa8be5d5f1
6543 commented 2022-04-30 16:48:26 +00:00
Owner
Copy Link

CI fail related

CI fail related
jolheiser merged commit 319a978c6c into master 2022-05-01 19:09:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
noerw
zeripath
Labels
Clear labels   
has/backport

   
has/pull

   
in progress

   
invalid

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
need/backport

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#570
No description provided.
Delete Branch "arkamar/go-sdk:allow-comments-only-review"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?