Allow PR review with comments only #570

Merged
jolheiser merged 2 commits from arkamar/go-sdk:allow-comments-only-review into master 2022-05-01 19:09:35 +00:00
Contributor

It is common to create PR review with Comments only, where foreword Body is empty. This is allowed by Gitea API, therefore SDK should return empty body error only if there are no comments.

It is common to create PR review with Comments only, where foreword Body is empty. This is allowed by Gitea API, therefore SDK should return empty body error only if there are no comments.
arkamar added 1 commit 2022-02-17 08:40:50 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
c8c15277ab
Allow PR review with comments only
It is common to create PR review with Comments only, where foreword Body
is empty. This is allowed by Gitea API, therefore SDK should return
empty body error only if there are no comments.

Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
noerw approved these changes 2022-03-08 22:18:20 +00:00
Owner

So then reject a pull request with no comment is impossible?

So then reject a pull request with no comment is impossible?
zeripath approved these changes 2022-03-28 23:26:44 +00:00
Owner

Could you update your branch? After that CI should be able to run. ?

Could you update your branch? After that CI should be able to run. ?
lunny added 1 commit 2022-04-30 16:21:15 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
fa8be5d5f1
Merge branch 'master' into allow-comments-only-review
Owner

CI fail related

CI fail related
jolheiser merged commit 319a978c6c into master 2022-05-01 19:09:35 +00:00
Sign in to join this conversation.
No description provided.