Add response to ReadRepoNotifications #590

Merged
6543 merged 11 commits from Gusted/go-sdk:notification-api-response into master 2022-05-15 15:47:38 +00:00
Contributor
- This is a breaking change. - Return the relevant notifications when the Gitea server is 1.16.0 or higher. - Ref: https://github.com/go-gitea/gitea/pull/17064 - Resolves #543
Gusted added 1 commit 2022-05-03 00:56:46 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
33e75639b6
Add response to ReadRepoNotifications
- This is a breaking change.
- Return the relevant notifications when the Gitea server is 1.16.0 or
higher.
- Ref: https://github.com/go-gitea/gitea/pull/17064
- Resolves #543
Gusted added 1 commit 2022-05-03 01:26:17 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
5c31ce14f0
Implement other part
Gusted added 1 commit 2022-05-03 01:27:33 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
4cfdcef551
Fix CI
Gusted added 1 commit 2022-05-03 01:28:36 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
d2279674fe
Correct amount
Author
Contributor
Tests fails due to: https://github.com/go-gitea/gitea/pull/19589
Gusted added 1 commit 2022-05-03 01:29:48 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
4bf2701e99
Fix revive lint
Gusted added 1 commit 2022-05-03 01:33:04 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
e614684d4e
Poor CI
Gusted added 1 commit 2022-05-03 14:18:33 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
1b2d1a157d
Empty commit
Gusted added 1 commit 2022-05-03 14:20:37 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
3d68477257
Another empty commit
Author
Contributor
https://drone.gitea.com/gitea/go-sdk/525/1/2 Docker is stuck?
6543 added the
kind/breaking
label 2022-05-03 17:44:23 +00:00
6543 added this to the v0.16.0 milestone 2022-05-03 17:44:28 +00:00
Owner

since it's a breaking change, can you add a note into https://gitea.com/gitea/go-sdk/src/branch/master/docs/migrate-v0.15-to-v0.16.md ?

since it's a breaking change, can you add a note into https://gitea.com/gitea/go-sdk/src/branch/master/docs/migrate-v0.15-to-v0.16.md ?
6543 added the
kind/enhancement
label 2022-05-03 17:45:18 +00:00
Owner

I have restarted CI. Look like it will fail randomly.

I have restarted CI. Look like it will fail randomly.
Gusted added 1 commit 2022-05-12 21:24:32 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
b3a248dde1
Add migration note
Author
Contributor

Added the migration note b3a248dde1

Added the migration note https://gitea.com/gitea/go-sdk/commit/b3a248dde18afbe6a746ef9676b2aeef4bd9e7c3
6543 reviewed 2022-05-14 15:23:01 +00:00
@ -161,3 +161,3 @@
// ReadNotification mark notification thread as read by ID
// It optionally takes a second argument if status has to be set other than 'read'
func (c *Client) ReadNotification(id int64, status ...NotifyStatus) (*Response, error) {
// The relevant notification will be returned as the first parameter when the Gitea server is 1.16.0 or higher.
Owner
-// The relevant notification will be returned  as the first parameter when the Gitea server is 1.16.0 or higher.
+// The relevant notification will be returned as the first parameter when the Gitea server is 1.16.0 or higher.
```diff -// The relevant notification will be returned as the first parameter when the Gitea server is 1.16.0 or higher. +// The relevant notification will be returned as the first parameter when the Gitea server is 1.16.0 or higher. ```
Gusted marked this conversation as resolved
Gusted added 1 commit 2022-05-14 20:22:28 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
fcfee1d882
Fix comment
Co-Authored-By: 6543 <6543@obermui.de>
6543 approved these changes 2022-05-14 22:02:55 +00:00
6543 left a comment
Owner

CI fail is unrelated ...

CI fail is unrelated ...
Gusted added 1 commit 2022-05-15 11:20:20 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
849eac00d2
Merge branch 'master' into notification-api-response
6543 approved these changes 2022-05-15 13:05:48 +00:00
lunny approved these changes 2022-05-15 14:24:03 +00:00
6543 merged commit 99a9de3172 into master 2022-05-15 15:47:38 +00:00
Gusted deleted branch notification-api-response 2022-05-15 16:33:35 +00:00
Sign in to join this conversation.
No description provided.