gitea/go-sdk
44
46
Fork 72
Code Issues 21 Pull Requests 7 Actions Releases 19 Activity

Add ListPullRequestFiles #607

Merged
6543 merged 5 commits from qwerty287/go-sdk:changed-files into main 2022-10-16 18:33:30 +00:00
Conversation 3 Commits 5 Files Changed 2 +41
qwerty287 commented 2022-09-30 15:05:18 +00:00
Contributor
Copy Link

Was added in 1dfa28ffa5.

Was added in https://github.com/go-gitea/gitea/commit/1dfa28ffa557720d164a351783be64c9a47a0adb.
qwerty287 added 1 commit 2022-09-30 15:05:19 +00:00
Add ListPullRequestFiles
All checks were successful
continuous-integration/drone/pr Build is passing
Details
86ff09f8de
qwerty287 commented 2022-10-10 15:58:24 +00:00
Author
Contributor
Copy Link

@6543 @lunny @johlheiser Can you review this PR?

@6543 @lunny @johlheiser Can you review this PR?
lunny commented 2022-10-13 10:59:20 +00:00
Owner
Copy Link

Could you add some test?

Could you add some test?
👍 1
qwerty287 added 1 commit 2022-10-13 17:04:54 +00:00
Add test
Some checks failed
continuous-integration/drone/pr Build is failing
Details
fcded84307
qwerty287 commented 2022-10-13 17:13:48 +00:00
Author
Contributor
Copy Link

@lunny see fcded84307.

@lunny see https://gitea.com/gitea/go-sdk/commit/fcded84307e582a5fa02742b989d1aaedd191f25.
qwerty287 added 1 commit 2022-10-13 17:17:14 +00:00
fix lint
Some checks failed
continuous-integration/drone/pr Build is failing
Details
40b3d3e3ec
qwerty287 added 1 commit 2022-10-13 17:26:22 +00:00
fix test
All checks were successful
continuous-integration/drone/pr Build is passing
Details
ab9feb766a
6543 approved these changes 2022-10-13 21:50:05 +00:00
6543 added the
kind/feature
 label 2022-10-13 21:50:14 +00:00
6543 added this to the v0.16.0 milestone 2022-10-13 21:50:18 +00:00
6543 requested review from Maintainers 2022-10-13 21:50:36 +00:00
Gusted reviewed 2022-10-13 22:23:50 +00:00
gitea/pull.go Outdated
@ -63,0 +63,4 @@
// ChangedFile is a changed file in a diff
type ChangedFile struct {
Filename string `json:"filename"`
PreviousFilename string `json:"previous_filename,omitempty"`
Gusted commented 2022-10-13 22:23:50 +00:00
Contributor
Copy Link

omitempty is unnecessary to specify here, it's only used for marshalling JSON, not for unmarshalling(current use-case). Please remove it, as well for the other fields that have this tag.

`omitempty` is unnecessary to specify here, it's only used for marshalling JSON, not for unmarshalling(current use-case). Please remove it, as well for the other fields that have this tag.
qwerty287 commented 2022-10-14 05:37:45 +00:00
Author
Contributor
Copy Link

See ed80485f88

See https://gitea.com/gitea/go-sdk/commit/ed80485f884f9cca9eb9a0a6cf33915631ffa5e3
qwerty287 marked this conversation as resolved
qwerty287 added 1 commit 2022-10-14 05:36:49 +00:00
Remove omitempty
All checks were successful
continuous-integration/drone/pr Build is passing
Details
ed80485f88
Gusted approved these changes 2022-10-14 06:34:19 +00:00
6543 merged commit 1c9c71d84a into main 2022-10-16 18:33:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
6543
Gusted
Labels
Clear labels   
has/backport

   
has/pull

   
in progress

   
invalid

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/security

   
kind/testing

   
kind/translation

   
kind/ui

   
need/backport

   
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea
No Label
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
Milestone
Clear milestone
No items
No Milestone
v0.16.0
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#607
No description provided.
Delete Branch "qwerty287/go-sdk:changed-files"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?