Add ListPullRequestFiles #607

Merged
6543 merged 5 commits from qwerty287/go-sdk:changed-files into main 2022-10-16 18:33:30 +00:00
Contributor

Was added in 1dfa28ffa5.

Was added in https://github.com/go-gitea/gitea/commit/1dfa28ffa557720d164a351783be64c9a47a0adb.
qwerty287 added 1 commit 2022-09-30 15:05:19 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
86ff09f8de
Add `ListPullRequestFiles`
Author
Contributor

@6543 @lunny @johlheiser Can you review this PR?

@6543 @lunny @johlheiser Can you review this PR?
Owner

Could you add some test?

Could you add some test?
qwerty287 added 1 commit 2022-10-13 17:04:54 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
fcded84307
Add test
Author
Contributor
@lunny see https://gitea.com/gitea/go-sdk/commit/fcded84307e582a5fa02742b989d1aaedd191f25.
qwerty287 added 1 commit 2022-10-13 17:17:14 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
40b3d3e3ec
fix lint
qwerty287 added 1 commit 2022-10-13 17:26:22 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
ab9feb766a
fix test
6543 approved these changes 2022-10-13 21:50:05 +00:00
6543 added the
kind/feature
label 2022-10-13 21:50:14 +00:00
6543 added this to the v0.16.0 milestone 2022-10-13 21:50:18 +00:00
6543 requested review from Maintainers 2022-10-13 21:50:36 +00:00
Gusted reviewed 2022-10-13 22:23:50 +00:00
gitea/pull.go Outdated
@ -63,0 +63,4 @@
// ChangedFile is a changed file in a diff
type ChangedFile struct {
Filename string `json:"filename"`
PreviousFilename string `json:"previous_filename,omitempty"`
Contributor

omitempty is unnecessary to specify here, it's only used for marshalling JSON, not for unmarshalling(current use-case). Please remove it, as well for the other fields that have this tag.

`omitempty` is unnecessary to specify here, it's only used for marshalling JSON, not for unmarshalling(current use-case). Please remove it, as well for the other fields that have this tag.
Author
Contributor
See https://gitea.com/gitea/go-sdk/commit/ed80485f884f9cca9eb9a0a6cf33915631ffa5e3
qwerty287 marked this conversation as resolved
qwerty287 added 1 commit 2022-10-14 05:36:49 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
ed80485f88
Remove omitempty
Gusted approved these changes 2022-10-14 06:34:19 +00:00
6543 merged commit 1c9c71d84a into main 2022-10-16 18:33:30 +00:00
Sign in to join this conversation.
No description provided.