gitea/go-sdk
44
46
Fork 73
Code Issues 21 Pull Requests 6 Actions Releases 19 Activity

add func to DownloadReleaseAttachment #609

Closed
edieruby wants to merge 7 commits from edieruby/go-sdk:download.attachment into main
pull from: edieruby/go-sdk:download.attachment
merge into: gitea:main
Conversation 8 Commits 7 Files Changed 2 +1
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 424487f641 - Show all commits

1
gitea/attachment.go
View File

@ -110,6 +110,7 @@ func (c *Client) DeleteReleaseAttachment(user, repo string, release, id int64) (
return resp, err
}
// DownloadReleaseAttachment Download an Attachment of the Release by UUID
func (c *Client) DownloadReleaseAttachment(UUID string) ([]byte, *Response, error) {
6543 marked this conversation as resolved Outdated
lunny commented 2022-10-13 10:58:41 +00:00
Outdated
Review
Copy Link

A io.Reader return parameter maybe better?

A `io.Reader` return parameter maybe better?
edieruby commented 2022-10-13 12:14:01 +00:00
Outdated
Review
Copy Link

I will update it.

I will update it.
if err := escapeValidatePathSegments(&UUID); err != nil {
6543 marked this conversation as resolved
6543 commented 2022-11-12 00:22:49 +00:00
Review
Copy Link

asap there is an official api ... we could add this here instead and use the old method only as fallback

asap there is an official api ... we could add this here instead and use the old method only as fallback
return nil, nil, err