gitea/helm-chart
45
54
Fork 126
Code Issues 32 Pull Requests 8 Actions Releases 87 Activity

Drop custom probes #248

Merged
luhahn merged 1 commits from justusbunsi/helm-chart:feature/189-custom-probes into master 2021-12-13 08:50:09 +00:00
Conversation 0 Commits 1 Files Changed 3 +61 -69
justusbunsi commented 2021-11-16 19:33:44 +00:00
Member
Copy Link

As a replacement, the default probes are now fully configurable and used
as-is during Chart deployment.

Fixes: #189

⚠️ BREAKING ⚠️

Users have to remove the custom prefix from their probes, if customized.

As a replacement, the default probes are now fully configurable and used as-is during Chart deployment. Fixes: #189 ⚠️ BREAKING ⚠️ --- Users have to remove the `custom` prefix from their probes, if customized.
justusbunsi added this to the 5.0.0 milestone 2021-11-16 19:33:44 +00:00
justusbunsi added the
kind
breaking
kind
enhancement
 labels 2021-11-16 19:33:44 +00:00
luhahn requested changes 2021-11-17 14:28:44 +00:00
luhahn left a comment
Member
Copy Link

just a small typo

just a small typo
README.md Outdated
@ -39,1 +39,4 @@
## Chart upgrade from 4.x.x to 5.0.0
:warning: The most recend `5.0.0` update brings some breaking changes. Please note
luhahn commented 2021-11-17 14:27:49 +00:00
Member
Copy Link

most recent

most recent
justusbunsi commented 2021-11-17 19:02:02 +00:00
Author
Member
Copy Link

Good catch. Updated.

Good catch. Updated.
justusbunsi marked this conversation as resolved
luhahn approved these changes 2021-11-18 10:35:10 +00:00
luhahn left a comment
Member
Copy Link

Looks good to me, also tested the changes :)

Looks good to me, also tested the changes :)
justusbunsi added a new dependency 2021-11-19 18:42:22 +00:00
#239 Rework app.ini generation
justusbunsi removed a dependency 2021-11-19 18:42:38 +00:00
#239 Rework app.ini generation
justusbunsi added a new dependency 2021-11-19 18:48:13 +00:00
#239 Rework app.ini generation
justusbunsi added the
status
blocked
 label 2021-11-19 18:49:03 +00:00
justusbunsi added a new dependency 2021-11-19 18:49:53 +00:00
#244 Rework OAuth sources
justusbunsi force-pushed feature/189-custom-probes from 5652661d60 to 3a9667f7e1 2021-11-19 19:04:19 +00:00 Compare
justusbunsi force-pushed feature/189-custom-probes from 3a9667f7e1 to 41ff53a96b 2021-11-19 19:07:45 +00:00 Compare
justusbunsi added 1 commit 2021-11-19 21:26:22 +00:00
Drop custom probes 
As a replacement, the default probes are now fully configurable and used
as-is during Chart deployment.

Fixes: #189
All checks were successful
continuous-integration/drone/pr Build is passing
Details
b2941324fd
justusbunsi removed the
status
blocked
 label 2021-11-19 21:28:13 +00:00
justusbunsi removed a dependency 2021-11-19 21:28:27 +00:00
#239 Rework app.ini generation
zeripath approved these changes 2021-12-04 11:11:55 +00:00
luhahn merged commit bfa68f6f58 into master 2021-12-13 08:50:09 +00:00
luhahn referenced this issue from a commit 2021-12-13 08:50:09 +00:00
Drop custom probes (#248)
justusbunsi deleted branch feature/189-custom-probes 2021-12-20 12:00:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
luhahn
zeripath
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
5.0.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#244 Rework OAuth sources
gitea/helm-chart
Reference: gitea/helm-chart#248
No description provided.
Delete Branch "justusbunsi/helm-chart:feature/189-custom-probes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?