gitea/helm-chart
48
54
Fork 129
Code Issues 31 Pull Requests 8 Actions Releases 87 Activity

Add ServiceMonitor Prometheus selector label #116

Merged
lafriks merged 4 commits from Starefossen/helm-chart:fix-servicemonitor into master 2021-03-01 12:18:10 +00:00
Conversation 1 Commits 4 Files Changed 2 +4
Starefossen commented 2021-02-20 19:38:25 +00:00
Contributor
Copy Link

Add label to select what Prometheus you want to scrape the ServiceMonitor.

Add label to select what Prometheus you want to scrape the ServiceMonitor.
Starefossen added 2 commits 2021-02-20 19:38:26 +00:00
Add metrics.serviceMonitor.prometheusSelector to ServiceMontiro labels
All checks were successful
continuous-integration/drone/pr Build is passing
Details
2c8e4d07c8
Starefossen added spent time 2021-02-22 19:03:36 +00:00
30min
luhahn commented 2021-02-23 15:53:54 +00:00
Member
Copy Link

Thanks for the PR! I will test your changes tomorrow :)

Thanks for the PR! I will test your changes tomorrow :)
luhahn requested changes 2021-02-24 08:33:31 +00:00
Dismissed
templates/gitea/servicemonitor.yaml Outdated
@ -5,6 +5,9 @@ metadata:
name: {{ include "gitea.fullname" . }}
labels:
{{- include "gitea.labels" . | nindent 4 }}
{{- if .Values.monitoring.serviceMonitor.prometheusSelector }}
luhahn commented 2021-02-24 08:33:28 +00:00
Member
Copy Link

.Values.monitoring.serviceMonitor does not exist.

I think you mean:

.Values.metrics.serviceMonitor

.Values.monitoring.serviceMonitor does not exist. I think you mean: .Values.metrics.serviceMonitor
Starefossen commented 2021-02-24 11:37:21 +00:00
Author
Contributor
Copy Link

Good catch! ?

Good catch! ?
Starefossen marked this conversation as resolved
Starefossen added 1 commit 2021-02-24 11:37:09 +00:00
Fix prometheusSelector variable name
All checks were successful
continuous-integration/drone/pr Build is passing
Details
80092be46d
luhahn approved these changes 2021-02-26 08:53:03 +00:00
Dismissed
lafriks added 1 commit 2021-03-01 12:17:23 +00:00
Merge branch 'master' into fix-servicemonitor
All checks were successful
continuous-integration/drone/pr Build is passing
Details
69cb0e2597
lafriks approved these changes 2021-03-01 12:17:56 +00:00
Dismissed
lafriks merged commit 7ed82c7a63 into master 2021-03-01 12:18:10 +00:00
lafriks deleted branch fix-servicemonitor 2021-03-01 12:18:15 +00:00
lafriks added the
kind
enhancement
 label 2021-03-01 12:18:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Total Time Spent: 30 minutes
Starefossen
30 minutes
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#116
No description provided.
Delete Branch "Starefossen/helm-chart:fix-servicemonitor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?