gitea/helm-chart
48
54
Fork 129
Code Issues 30 Pull Requests 8 Actions Releases 88 Activity

Add app and version labels #121

Merged
lafriks merged 3 commits from Starefossen/helm-chart:app-labels into master 2021-03-01 12:20:56 +00:00
Conversation 1 Commits 3 Files Changed 2 +3 -1
Starefossen commented 2021-02-23 13:31:28 +00:00
Contributor
Copy Link

This pull request adds the app and version labels that are used by Istio.

Pods with app and version labels: We recommend adding an explicit app label and version label to the specification of the pods deployed using a Kubernetes Deployment. The app and version labels add contextual information to the metrics and telemetry that Istio collects.

  • The app label: Each deployment should have a distinct app label with a meaningful value. The app label is used to add contextual information in distributed tracing.

  • The version label: This label indicates the version of the application corresponding to the particular deployment.

From https://istio.io/latest/docs/ops/deployment/requirements/#pod-requirements

This pull request adds the `app` and `version` labels that are used by Istio. > Pods with app and version labels: We recommend adding an explicit app label and version label to the specification of the pods deployed using a Kubernetes Deployment. The app and version labels add contextual information to the metrics and telemetry that Istio collects. > > * The app label: Each deployment should have a distinct app label with a meaningful value. The app label is used to add contextual information in distributed tracing. > > * The version label: This label indicates the version of the application corresponding to the particular deployment. From https://istio.io/latest/docs/ops/deployment/requirements/#pod-requirements
Starefossen added 1 commit 2021-02-23 13:31:28 +00:00
Add app and version labels
All checks were successful
continuous-integration/drone/pr Build is passing
Details
725c6ce8d0
Starefossen started working 2021-02-23 13:32:03 +00:00
Starefossen stopped working 2021-02-23 13:32:06 +00:00
3s
luhahn commented 2021-02-23 15:56:00 +00:00
Member
Copy Link

Thanks for the PR! I will test your changes tomorrow :)

Thanks for the PR! I will test your changes tomorrow :)
luhahn reviewed 2021-02-24 08:10:00 +00:00
Dismissed
luhahn left a comment
Member
Copy Link

Not sure if this really is what we want

Not sure if this really is what we want
templates/_helpers.tpl Outdated
@ -39,3 +40,4 @@
{{ include "gitea.selectorLabels" . }}
{{- if .Chart.AppVersion }}
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
version: {{ .Chart.AppVersion | quote }}
luhahn commented 2021-02-24 08:09:30 +00:00
Member
Copy Link

with the current auto release this will result always in version 0.0.0.

with the current auto release this will result always in version 0.0.0.
Starefossen commented 2021-02-24 11:39:42 +00:00
Author
Contributor
Copy Link

In my latest gitea helm deployment this says version=1.13.2 ?

In my latest gitea helm deployment this says `version=1.13.2` ?
luhahn commented 2021-02-24 14:15:19 +00:00
Member
Copy Link

Sorry, i just noticed, that i was using my new helm install plugin for ansible. Which had some issues and printed some weird version :D

Of course it says version=1.13.2

my bad :D

Sorry, i just noticed, that i was using my new helm install plugin for ansible. Which had some issues and printed some weird version :D Of course it says version=1.13.2 my bad :D
lafriks marked this conversation as resolved
Starefossen added 1 commit 2021-02-24 11:35:59 +00:00
Add all of the labels to the pod specification
All checks were successful
continuous-integration/drone/pr Build is passing
Details
707f4c3cdb
luhahn approved these changes 2021-02-24 14:15:38 +00:00
Dismissed
lafriks added 1 commit 2021-03-01 12:19:22 +00:00
Merge branch 'master' into app-labels
All checks were successful
continuous-integration/drone/pr Build is passing
Details
b499ca93fb
lafriks approved these changes 2021-03-01 12:20:31 +00:00
Dismissed
lafriks merged commit 9213f0d1f5 into master 2021-03-01 12:20:56 +00:00
lafriks deleted branch app-labels 2021-03-01 12:21:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Total Time Spent: 3 seconds
Starefossen
3 seconds
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#121
No description provided.
Delete Branch "Starefossen/helm-chart:app-labels"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?