gitea/helm-chart
45
54
Fork 127
Code Issues 30 Pull Requests 8 Actions Releases 87 Activity

Fix admin + ldap configuration #183

Merged
luhahn merged 3 commits from justusbunsi/helm-chart:fix-admin-creation into master 2021-06-21 13:28:19 +00:00
Conversation 1 Commits 3 Files Changed 3 +5 -5
justusbunsi commented 2021-06-16 20:10:06 +00:00
Member
Copy Link

This fixes several flaws introduced by commits for #169 (see c49dc047a4).

  • Respect kebab-case ldap bind inline definition
  • Prevent camelCase ldap bind inline definition from being overridden by empty string
  • Create admin account when existingSecret is used
This fixes several flaws introduced by commits for #169 (see c49dc047a498973920e6743fa6c330fd2f81dd47). - Respect kebab-case ldap bind inline definition - Prevent camelCase ldap bind inline definition from being overridden by empty string - Create admin account when `existingSecret` is used
zeripath approved these changes 2021-06-16 20:27:18 +00:00
luhahn requested changes 2021-06-17 09:39:22 +00:00
luhahn left a comment
Member
Copy Link

Just a small issue here, the rest seems okay

Just a small issue here, the rest seems okay
templates/_helpers.tpl Outdated
@ -109,3 +109,3 @@
{{- define "gitea.ldap_settings" -}}
{{- if or (not (hasKey .Values.gitea.ldap "bindDn")) (not (hasKey .Values.gitea.ldap "bind-dn")) -}}
{{- if and (not (hasKey .Values.gitea.ldap "bindDn")) (not (hasKey .Values.gitea.ldap "bind-dn")) -}}
luhahn commented 2021-06-17 09:38:20 +00:00
Member
Copy Link

and is not the right operator here. The values can be bindDn or bind-dn an and would mean, that both values shall not be present.

and is not the right operator here. The values can be bindDn or bind-dn an and would mean, that both values shall not be present.
luhahn marked this conversation as resolved
luhahn approved these changes 2021-06-17 09:40:59 +00:00
luhahn left a comment
Member
Copy Link

Nevermind, i should not review after getting the covid vaccine. Im dizzy, sorry:D

Nevermind, i should not review after getting the covid vaccine. Im dizzy, sorry:D
justusbunsi added a new dependency 2021-06-19 14:10:28 +00:00
#178 Rewrite init script
luhahn commented 2021-06-21 09:58:33 +00:00
Member
Copy Link

Just tested this and it works fine. However the next release needs to be 3.2.0 because of the database updates.

Just tested this and it works fine. However the next release needs to be 3.2.0 because of the database updates.
justusbunsi force-pushed fix-admin-creation from 3372382517 to e721e1e14b 2021-06-21 13:14:07 +00:00 Compare
luhahn merged commit d6eb50ca35 into master 2021-06-21 13:28:19 +00:00
justusbunsi deleted branch fix-admin-creation 2021-06-21 15:04:46 +00:00
justusbunsi removed a dependency 2021-06-21 16:49:27 +00:00
#178 Rewrite init script
Sign in to join this conversation.
Reviewers
No reviewers
zeripath
luhahn
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#183
No description provided.
Delete Branch "justusbunsi/helm-chart:fix-admin-creation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?