gitea/helm-chart
45
54
Fork 127
Code Issues 32 Pull Requests 7 Actions Releases 87 Activity

Fix regression for unspecified DOMAIN and ROOT_URL #185

Merged
techknowlogick merged 2 commits from justusbunsi/helm-chart:fix-ingress-regression into master 2021-06-29 19:24:45 +00:00
Conversation 0 Commits 2 Files Changed 1 +2 -2
justusbunsi commented 2021-06-25 12:08:38 +00:00
Member
Copy Link

In case a user did not specify DOMAIN in .Values.gitea.config.server,
the chart generated incorrect value for that app.ini setting so that
Gitea crashed on startup.

Same for ROOT_URL.

In case a user did not specify DOMAIN in .Values.gitea.config.server, the chart generated incorrect value for that app.ini setting so that Gitea crashed on startup. Same for ROOT_URL.
justusbunsi force-pushed fix-ingress-regression from 6ec02ce9b7 to 8445db79e5 2021-06-25 15:27:56 +00:00 Compare
justusbunsi added the
kind
bug
 label 2021-06-26 08:53:51 +00:00
luhahn approved these changes 2021-06-28 07:22:57 +00:00
luhahn left a comment
Member
Copy Link

tested -> looks good :)

tested -> looks good :)
techknowlogick approved these changes 2021-06-29 19:24:27 +00:00
techknowlogick added 1 commit 2021-06-29 19:24:34 +00:00
Merge branch 'master' into fix-ingress-regression
All checks were successful
continuous-integration/drone/pr Build is passing
Details
6b359dcdce
techknowlogick merged commit 6a6eb35106 into master 2021-06-29 19:24:45 +00:00
justusbunsi deleted branch fix-ingress-regression 2021-06-29 19:29:44 +00:00
justusbunsi added this to the Release 4.0.0 milestone 2021-06-30 10:20:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
luhahn
techknowlogick
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Release 4.0.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#185
No description provided.
Delete Branch "justusbunsi/helm-chart:fix-ingress-regression"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?