gitea/helm-chart
45
54
Fork 127
Code Issues 33 Pull Requests 9 Actions Releases 87 Activity

feat/markdownlint #200

Merged
lunny merged 1 commits from volker.raschek/helm-chart:feat/markdownlint into master 2021-11-05 04:06:49 +00:00
Conversation 7 Commits 1 Files Changed 3 +487 -266
volker.raschek commented 2021-06-30 19:33:24 +00:00
Contributor
Copy Link

Hi,
this patch contains a markdownlinter. I think this has the advantage that all users stick to the same format and the README.md follows a consistent structure.

The markdownlinter can be configured via the .markdownlint.yaml file. All possible options are here documented.

I have created the initialie configuration. However, can be adapted to suggestions for change. Has of course the consequence that if necessary the README.md would have to be adapted. I have formatted this in advance according to the defined rules.

For users which use visual-code as IDE is additionally a plugin available.

Hi, this patch contains a markdownlinter. I think this has the advantage that all users stick to the same format and the `README.md` follows a consistent structure. The markdownlinter can be configured via the `.markdownlint.yaml` file. All possible options are [here](https://github.com/DavidAnson/markdownlint/blob/main/schema/.markdownlint.yaml) documented. I have created the initialie configuration. However, can be adapted to suggestions for change. Has of course the consequence that if necessary the `README.md` would have to be adapted. I have formatted this in advance according to the defined rules. For users which use visual-code as IDE is additionally a plugin [available](https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint).
👍 1
volker.raschek added 1 commit 2021-06-30 19:33:24 +00:00
[Close #161] fix: SSH not working due missing security capability 
This patch add the SYS_CHROOT capability if the securityContext is
undefined. Otherwise the SSH Server does not work correctly as described
in the issue #161.
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7121d5e804
volker.raschek force-pushed feat/markdownlint from aa9f1af8d1 to fb46b402f5 2021-06-30 19:37:24 +00:00 Compare
volker.raschek force-pushed feat/markdownlint from fb46b402f5 to b45e5267a4 2021-06-30 19:40:27 +00:00 Compare
justusbunsi commented 2021-06-30 19:54:13 +00:00
Member
Copy Link

? This is going to be awesome once finished. Thank you for your invested time so far.

? This is going to be awesome once finished. Thank you for your invested time so far.
volker.raschek commented 2021-06-30 20:00:20 +00:00
Author
Contributor
Copy Link

Hi @justusbunsi,
can you mark this PR as dependency of #176? Otherwise I must revert my changes inside the README.md file.

Furthermore I tried to start the container. However, the pipeline always breaks. I guess that the drone instance has no x86_64 build node?

Hi @justusbunsi, can you mark this PR as dependency of #176? Otherwise I must revert my changes inside the `README.md` file. Furthermore I tried to start the container. However, the pipeline always breaks. I guess that the drone instance has no x86_64 build node?
justusbunsi commented 2021-06-30 20:30:27 +00:00
Member
Copy Link

Yes, I'll add the dependency on thursday. Right now I'm writing with the app.
Shall I add #196 as dependency as well?

Aside that, please ensure that Gitea is spelled Gitea with a capital G at the beginning since this is the official spelling. ?

Yes, I'll add the dependency on thursday. Right now I'm writing with the app. Shall I add #196 as dependency as well? Aside that, please ensure that Gitea is spelled `Gitea` with a capital G at the beginning since this is the official spelling. ?
justusbunsi added the
kind
docs
 label 2021-07-08 05:26:19 +00:00
volker.raschek force-pushed feat/markdownlint from b45e5267a4 to 168210bbef 2021-09-08 18:34:54 +00:00 Compare
justusbunsi commented 2021-10-08 14:23:14 +00:00
Member
Copy Link

@volker.raschek Could you please resolve the conflicts? What's the status of this PR?

@volker.raschek Could you please resolve the conflicts? What's the status of this PR?
volker.raschek commented 2021-10-08 14:35:08 +00:00
Author
Contributor
Copy Link

Hi @justusbunsi,
the problem is, that in your CI are only arm64 nodes available. I tried first to build an image for arm with my raspberry pi, but the image is not arm64, but arm. I think in two weeks I can provide an arm64 based image to get running the CI.

Hi @justusbunsi, the problem is, that in your CI are only arm64 nodes available. I tried first to build an image for arm with my raspberry pi, but the image is not arm64, but arm. I think in two weeks I can provide an arm64 based image to get running the CI.
:gitea: 1
volker.raschek force-pushed feat/markdownlint from 07177b0d83 to 7dad400dfb 2021-10-23 14:36:07 +00:00 Compare
volker.raschek changed title from WIP: feat/markdownlint to feat/markdownlint 2021-10-23 14:37:44 +00:00
volker.raschek commented 2021-10-23 14:39:38 +00:00
Author
Contributor
Copy Link

Hi @justusbunsi,
I uploaded an arm64 image of markdownlint and the CI works now correctly.

Please do a review.

Volker

Hi @justusbunsi, I uploaded an arm64 image of markdownlint and the CI works now correctly. Please do a review. Volker
lunny reviewed 2021-10-24 08:03:16 +00:00
README.md Outdated
@ -632,4 +686,0 @@
|mariadb.primary.service.port|Port to connect to mariadb service|3306|
|mariadb.primary.persistence.size|Persistence size for mariadb |10Gi|
## Local development & testing
lunny commented 2021-10-24 08:03:16 +00:00
Owner
Copy Link

Why removed these?

Why removed these?
volker.raschek force-pushed feat/markdownlint from 7dad400dfb to 76ab081c5d 2021-10-24 08:12:51 +00:00 Compare
volker.raschek commented 2021-10-24 08:13:57 +00:00
Author
Contributor
Copy Link

Hi @lunny,

that was not intentional. The lines were probably lost during the rebase. I have adapted the README.md accordingly.

Hi @lunny, that was not intentional. The lines were probably lost during the rebase. I have adapted the README.md accordingly.
lunny approved these changes 2021-10-24 08:26:06 +00:00
pat-s approved these changes 2021-11-02 10:55:37 +00:00
pat-s left a comment
Member
Copy Link

Thanks, LGTM! This could also be added to the main Gitea repo.

Thanks, LGTM! This could also be added to the main Gitea repo.
lunny merged commit 82763f109b into master 2021-11-05 04:06:49 +00:00
lunny referenced this issue from a commit 2021-11-05 04:06:50 +00:00
feat/markdownlint (#200)
Sign in to join this conversation.
Reviewers
No reviewers
lunny
pat-s
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#200
No description provided.
Delete Branch "volker.raschek/helm-chart:feat/markdownlint"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?