gitea/helm-chart
45
54
Fork 128
Code Issues 31 Pull Requests 7 Actions Releases 87 Activity

Remove builtIn dependency values #268

Merged
luhahn merged 2 commits from move-dependency-enable into master 2021-12-22 15:41:36 +00:00
Conversation 1 Commits 2 Files Changed 4 +52 -39
luhahn commented 2021-12-21 11:24:56 +00:00
Member
Copy Link

⚠️ Breaking

Moved the values to enable the dependencies into the dependencies itself, this way we don't need a seperate field in the values and it is more obvious how to enable for example postgresql.

⚠️ Breaking Moved the values to enable the dependencies into the dependencies itself, this way we don't need a seperate field in the values and it is more obvious how to enable for example postgresql.
luhahn added the
kind
breaking
 label 2021-12-21 11:25:08 +00:00
luhahn added this to the 5.0.0 milestone 2021-12-21 11:25:15 +00:00
luhahn force-pushed move-dependency-enable from 14343480f2 to f7de50972a 2021-12-21 12:04:00 +00:00 Compare
justusbunsi requested changes 2021-12-21 12:18:30 +00:00
justusbunsi left a comment
Member
Copy Link

README needs to be modified. The other parts LGTM.

README needs to be modified. The other parts LGTM.
README.md Outdated
@ -275,3 +342,4 @@
### External Database
An external Database can be used instead of builtIn PostgreSQL or MySQL.
justusbunsi commented 2021-12-21 12:06:05 +00:00
Member
Copy Link

In the example below this line there is still a reference to gitea.database.builtIn.postgresql.enabled (L: 348+). Same for gitea.cache.builtIn.enabled (L: 433+).

Should be replaced with new structure.

In the example below this line there is still a reference to `gitea.database.builtIn.postgresql.enabled` (L: 348+). Same for `gitea.cache.builtIn.enabled` (L: 433+). Should be replaced with new structure.
luhahn marked this conversation as resolved
luhahn force-pushed move-dependency-enable from f7de50972a to 1a036fd941 2021-12-21 12:22:51 +00:00 Compare
luhahn requested review from justusbunsi 2021-12-21 12:23:01 +00:00
justusbunsi reviewed 2021-12-21 13:15:08 +00:00
README.md Outdated
@ -788,6 +855,7 @@ The following parameters are the defaults set by this chart
| `mariadb.auth.rootPassword` | Password for the root user. | `gitea` |
| `mariadb.primary.service.port` | Port to connect to MariaDB service | `3306` |
| `mariadb.primary.persistence.size` | Persistence size for MariaDB | `10Gi` |
| `mariadb.enabled` | Enable MariaDB dependency | `true` |
justusbunsi commented 2021-12-21 13:15:08 +00:00
Member
Copy Link

True should be false according to values.yaml file.

True should be false according to values.yaml file.
luhahn force-pushed move-dependency-enable from 1a036fd941 to f188e83774 2021-12-21 13:19:32 +00:00 Compare
justusbunsi approved these changes 2021-12-21 13:26:40 +00:00
justusbunsi left a comment
Member
Copy Link

If I didn't miss anything, LGTM now.

If I didn't miss anything, LGTM now.
luhahn force-pushed move-dependency-enable from f188e83774 to d2b1a85aa4 2021-12-22 11:39:41 +00:00 Compare
justusbunsi commented 2021-12-22 12:30:08 +00:00
Member
Copy Link

My approval is still valid after reviewing the latest changes. ?

My approval is still valid after reviewing the latest changes. ?
wxiaoguang reviewed 2021-12-22 13:20:17 +00:00
README.md Outdated
@ -194,0 +218,4 @@
It is possible to enable profiling in the Gitea configuration.
However we do not recommend to run with ENABLE_PPROF for a longer period,
since it will dump specific files to your disk,
which will eventually fill up your inode table.
wxiaoguang commented 2021-12-22 13:20:17 +00:00
Member
Copy Link

We will have a fix soon, so do not worry about it.

I think we can safely remove the section about Enable Profiling now.

We will have a fix soon, so do not worry about it. I think we can safely remove the section about `Enable Profiling` now.
luhahn commented 2021-12-22 13:24:29 +00:00
Author
Member
Copy Link

:D Alrightm removed it again

:D Alrightm removed it again
luhahn marked this conversation as resolved
luhahn force-pushed move-dependency-enable from d2b1a85aa4 to a258fcf27f 2021-12-22 13:24:23 +00:00 Compare
zeripath approved these changes 2021-12-22 14:39:32 +00:00
luhahn merged commit d97ea18626 into master 2021-12-22 15:41:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
justusbunsi
zeripath
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
5.0.0
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#268
No description provided.
Delete Branch "move-dependency-enable"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?