gitea/helm-chart
45
54
Fork 127
Code Issues 30 Pull Requests 8 Actions Releases 87 Activity

Gpg init fails to import key #370 #371

Merged
justusbunsi merged 2 commits from dajoen74/helm-chart:fixgpgimport into main 2022-10-18 05:47:22 +00:00
Conversation 3 Commits 2 Files Changed 2 +12 -1
dajoen74 commented 2022-10-17 19:20:48 +00:00
Contributor
Copy Link

Description of the change

The init container for gpg key import doesn´t work. There is a not a tty error.

Benefits

This will run gpg in batch mode. Eliminating the tty error.

Possible drawbacks

None that I can think off.

Applicable issues

Checklist

  • Parameters are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Breaking changes are documented in the README.md
### Description of the change The init container for gpg key import doesn´t work. There is a not a tty error. ### Benefits This will run gpg in batch mode. Eliminating the tty error. ### Possible drawbacks None that I can think off. ### Applicable issues - fixes #370 ### Checklist - [X] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm) - [X] Breaking changes are documented in the `README.md`
dajoen74 added 1 commit 2022-10-17 19:20:48 +00:00
Gpg init fails to import key #370
All checks were successful
continuous-integration/drone/pr Build is passing
Details
a7935ce097
techknowlogick approved these changes 2022-10-17 19:28:43 +00:00
justusbunsi commented 2022-10-17 19:49:57 +00:00
Member
Copy Link

I was wondering why no unit tests failed for this change, before realizing I missed adding one for the added code snipped.

Do you mind adding one, ensuring that the --batch flag never get removed again?

I was wondering why no unit tests failed for this change, before realizing I missed adding one for the added code snipped. Do you mind adding one, ensuring that the `--batch` flag never get removed again?
justusbunsi added the
kind
bug
 label 2022-10-17 19:50:26 +00:00
dajoen74 commented 2022-10-18 05:22:52 +00:00
Author
Contributor
Copy Link

I'll give it a shot. First time writing a unit test for me.

I'll give it a shot. First time writing a unit test for me.
❤️ 1
dajoen74 added 1 commit 2022-10-18 05:36:17 +00:00
Added unit test for gpg batch mode
All checks were successful
continuous-integration/drone/pr Build is passing
Details
3eb5820c11
dajoen74 commented 2022-10-18 05:36:59 +00:00
Author
Contributor
Copy Link

This should do it.

This should do it.
justusbunsi approved these changes 2022-10-18 05:45:35 +00:00
justusbunsi left a comment
Member
Copy Link

LGTM

LGTM
justusbunsi merged commit 57a1cd27d9 into main 2022-10-18 05:47:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
techknowlogick
justusbunsi
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#371
No description provided.
Delete Branch "dajoen74/helm-chart:fixgpgimport"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?