gitea/helm-chart
45
54
Fork 127
Code Issues 30 Pull Requests 8 Actions Releases 87 Activity

test: use official unittest plugin #410

Merged
pat-s merged 3 commits from viceice/gitea-helm-chart:test/unitests into main 2023-03-21 15:53:14 +00:00
Conversation 4 Commits 3 Files Changed 4 +6 -6
viceice commented 2023-03-07 12:48:24 +00:00
Contributor
Copy Link

Description of the change

Switch to official helm-unittest which is now alive again at https://github.com/helm-unittest/helm-unittest

Applicable issues

Checklist

  • Parameters are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Breaking changes are documented in the README.md
### Description of the change Switch to official `helm-unittest` which is now alive again at https://github.com/helm-unittest/helm-unittest ### Applicable issues - ref #199 ### Checklist <!-- [Place an '[X]' (no spaces) in all applicable fields. Please remove unrelated fields.] --> - [ ] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm) - [ ] Breaking changes are documented in the `README.md`
viceice added 1 commit 2023-03-07 12:48:24 +00:00
test: use official unittest plugin
All checks were successful
continuous-integration/drone/pr Build is passing
Details
d06c4df565
lunny added the
kind
testing
 label 2023-03-07 13:47:37 +00:00
justusbunsi commented 2023-03-07 15:27:44 +00:00
Member
Copy Link

Awesome, thanks for the PR. There is another mention of the current helm plugin in CONTRIBUTING.md that needs to be changed. Otherwise lgtm.

Awesome, thanks for the PR. There is another mention of the current helm plugin in `CONTRIBUTING.md` that needs to be changed. Otherwise lgtm.
👍 1 👀 1
pat-s approved these changes 2023-03-07 16:49:37 +00:00
viceice added 1 commit 2023-03-21 05:37:16 +00:00
docs: update helm-unittest url inside contributing guide 
Signed-off-by: Michael Kriese <michael.kriese@visualon.de>
All checks were successful
continuous-integration/drone/pr Build is passing
Details
557484a217
viceice added 1 commit 2023-03-21 05:37:26 +00:00
Merge branch 'main' into test/unitests
All checks were successful
continuous-integration/drone/pr Build is passing
Details
10da24020b
viceice requested review from pat-s 2023-03-21 05:37:46 +00:00
viceice commented 2023-03-21 05:38:08 +00:00
Author
Contributor
Copy Link

Awesome, thanks for the PR. There is another mention of the current helm plugin in CONTRIBUTING.md that needs to be changed. Otherwise lgtm.

> Awesome, thanks for the PR. There is another mention of the current helm plugin in `CONTRIBUTING.md` that needs to be changed. Otherwise lgtm.
viceice closed this pull request 2023-03-21 05:38:08 +00:00
viceice reopened this pull request 2023-03-21 05:38:15 +00:00
viceice commented 2023-03-21 05:38:34 +00:00
Author
Contributor
Copy Link

Fixed the contributing guide ?

Fixed the contributing guide ?
justusbunsi approved these changes 2023-03-21 05:59:58 +00:00
justusbunsi left a comment
Member
Copy Link

LGTM

LGTM
❤️ 1
viceice commented 2023-03-21 12:43:48 +00:00
Author
Contributor
Copy Link

@pat-s Can you please approve again. ?

@pat-s Can you please approve again. ?
pat-s approved these changes 2023-03-21 15:52:39 +00:00
pat-s merged commit 1be9fae08b into main 2023-03-21 15:53:14 +00:00
viceice deleted branch test/unitests 2023-03-22 11:44:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
justusbunsi
pat-s
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#410
No description provided.
Delete Branch "viceice/gitea-helm-chart:test/unitests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?