gitea/helm-chart
45
54
Fork 127
Code Issues 31 Pull Requests 9 Actions 2 Releases 87 Activity

Fix wrong reference to existingKey #415

Merged
justusbunsi merged 2 commits from towo/helm-chart:main into main 2023-03-21 06:16:42 +00:00
Conversation 0 Commits 2 Files Changed 3 +3 -3
towo commented 2023-03-19 00:09:59 +00:00
Contributor
Copy Link

Description of the change

Fix a wrong reference to signing.existingKey, signing.existingSecret was what was meant and what is used in the chart.

Benefits

Less confusion when trying to use the Helm chart.

Possible drawbacks

Evangelists of existingKey storming the barricades even though existingKey is long dead.

Applicable issues

None, nobody noticed enough to care, apparently.

### Description of the change Fix a wrong reference to `signing.existingKey`, `signing.existingSecret` was what was meant and what is used in the chart. ### Benefits Less confusion when trying to use the Helm chart. ### Possible drawbacks Evangelists of `existingKey` storming the barricades even though `existingKey` is long dead. ### Applicable issues None, nobody noticed enough to care, apparently.
towo added 2 commits 2023-03-19 00:10:00 +00:00
Fix unit test as well
All checks were successful
continuous-integration/drone/pr Build is passing
Details
4fe20f0afd
towo changed title from main to Fix wrong reference to `existingKey` 2023-03-19 00:10:12 +00:00
pat-s approved these changes 2023-03-20 10:08:39 +00:00
justusbunsi approved these changes 2023-03-21 06:15:25 +00:00
justusbunsi left a comment
Member
Copy Link

LGTM

LGTM
justusbunsi merged commit 4869aed6ad into main 2023-03-21 06:16:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pat-s
justusbunsi
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#415
No description provided.
Delete Branch "towo/helm-chart:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?