Change env-to-ini prefix and remove custom prefix #464
No reviewers
Labels
No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitea/helm-chart#464
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "remove-env-to-init-prefix"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description of the change
Change env-to-ini prefix and remove custom prefix.
GITEA
is the default prefix.Benefits
Compatibility wit v1.20 (
-p
got removed)Possible drawbacks
None
Additional information
See https://github.com/go-gitea/gitea/pull/25799
Tested with Gitea < 1.20 and >= 1.20
From a user pov this change is a breaking one. Chart users are able to add custom envs with the previously used prefix to inject them into the ini building. Those envs must be changed. There is no backwards compatibility. We should explicitly state this. The actual changes look good.
I am not sure about what's this line is used for:
If you want to filter the config options, maybe it should be
grep GITEA__
(double underline) ?@wxiaoguang
Good point. The old value was somewhat unique amongst the envs. This line saves the environment variables that exists prior to the script execution. It is necessary to override provided the ini values in the correct order.
https://gitea.com/gitea/helm-chart#user-defined-environment-variables-in-app-ini
Added a comment to the script, thanks everyone!
I've marked this PR breaking. For release notes.