Login to docker to fix workflow #526

Merged
techknowlogick merged 4 commits from fix-test-workflow into main 2023-10-10 19:48:00 +00:00
Member

Same as for the release workflow.

Same as for the release workflow.
pat-s added 1 commit 2023-10-05 19:53:02 +00:00
fix test workflow
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 15s
892cc455a3
pat-s added 1 commit 2023-10-05 19:53:51 +00:00
actually install docker
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 44s
9752166116
pat-s added 1 commit 2023-10-05 19:58:25 +00:00
fix whitespace
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 43s
3cc6707fab
techknowlogick requested changes 2023-10-06 04:07:37 +00:00
techknowlogick left a comment
Owner

blocking this as it opens up secrets to PRs

blocking this as it opens up secrets to PRs
Author
Member

Good catch.

I see two solutions:

  • a read-only token
  • selectively approving PRs

I'd favor (1). Your opinion?

Good catch. I see two solutions: - a read-only token - selectively approving PRs I'd favor (1). Your opinion?
pat-s added 1 commit 2023-10-09 18:36:23 +00:00
use personal docker token
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 47s
2daf2b9a10
Author
Member

@techknowlogick I've used a personal read-only public token of my own Docker account now to move forward. If you have time, it would be great to add a token from the Gitea docker org. Public read-only tokens should only have a use case for rate limiting AFAICS.

@techknowlogick I've used a personal read-only public token of my own Docker account now to move forward. If you have time, it would be great to add a token from the Gitea docker org. Public read-only tokens should only have a use case for rate limiting AFAICS.

@pat-s I've created some temporary RO tokens DOCKER_RO_USERNAME and DOCKER_RO_PASSWORD under my personal username, as I'm having some trouble getting into the giteabot docker hub account. Once I get access, I'll be able to update them :)

@pat-s I've created some temporary RO tokens `DOCKER_RO_USERNAME` and `DOCKER_RO_PASSWORD` under my personal username, as I'm having some trouble getting into the giteabot docker hub account. Once I get access, I'll be able to update them :)
Author
Member

Thanks! Though this wouldn't have been needed as my last comment tried to communicate I already did the same with DOCKER_USERNAME_PUBLIC 😄

For now, I only need an approval here to move forward. I want to get the renovate updates auto-merged again.

Thanks! Though this wouldn't have been needed as my last comment tried to communicate I already did the same with `DOCKER_USERNAME_PUBLIC` 😄 For now, I only need an approval here to move forward. I want to get the renovate updates auto-merged again.
techknowlogick merged commit 9802e9ae41 into main 2023-10-10 19:48:00 +00:00
techknowlogick deleted branch fix-test-workflow 2023-10-10 19:48:01 +00:00
Sign in to join this conversation.
No description provided.