Fix domain macro #560

Merged
pat-s merged 2 commits from justusbunsi/helm-chart:supersede-359 into main 2023-11-14 22:23:01 +00:00
Member

Description of the change

This supersedes #359 by fixing the fallback domain value when no ingress host is defined.

Memcached is not used anymore. PostgreSQL macro has already been fixed otherwise.

Checklist

  • Templating unittests are added
### Description of the change This supersedes #359 by fixing the fallback domain value when no ingress host is defined. Memcached is not used anymore. PostgreSQL macro has already been fixed otherwise. ### Checklist - [x] Templating unittests are added
justusbunsi added the
kind
bug
label 2023-11-11 16:38:56 +00:00
justusbunsi added 1 commit 2023-11-11 16:38:56 +00:00
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 34s
9987aeb4c8
Fix domain macro
This supersedes #359 and fixes the fallback domain value when no ingress
host is defined.

Memcached is not used anymore. Postgresql macro has already been fixed
otherwise.

Signed-off-by: justusbunsi <sk.bunsenbrenner@gmail.com>
justusbunsi requested review from pat-s 2023-11-13 17:34:30 +00:00
pat-s approved these changes 2023-11-14 22:18:11 +00:00
pat-s left a comment
Member

LGTM, thanks! Nice tests!

LGTM, thanks! Nice tests!
pat-s added 1 commit 2023-11-14 22:18:23 +00:00
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 1m4s
d3306d71e0
Merge branch 'main' into supersede-359
pat-s merged commit 7499fecc1a into main 2023-11-14 22:23:01 +00:00
pat-s referenced this issue from a commit 2023-11-14 22:23:02 +00:00
justusbunsi deleted branch supersede-359 2023-11-16 17:42:43 +00:00
Sign in to join this conversation.
No description provided.