gitea/helm-chart
45
54
Fork 127
Code Issues 30 Pull Requests 8 Actions Releases 87 Activity

Fix domain macro #560

Merged
pat-s merged 2 commits from justusbunsi/helm-chart:supersede-359 into main 2023-11-14 22:23:01 +00:00
Conversation 0 Commits 2 Files Changed 2 +68 -1
justusbunsi commented 2023-11-11 16:38:56 +00:00
Member
Copy Link

Description of the change

This supersedes #359 by fixing the fallback domain value when no ingress host is defined.

Memcached is not used anymore. PostgreSQL macro has already been fixed otherwise.

Checklist

  • Templating unittests are added
### Description of the change This supersedes #359 by fixing the fallback domain value when no ingress host is defined. Memcached is not used anymore. PostgreSQL macro has already been fixed otherwise. ### Checklist - [x] Templating unittests are added
justusbunsi added the
kind
bug
 label 2023-11-11 16:38:56 +00:00
justusbunsi added 1 commit 2023-11-11 16:38:56 +00:00
Fix domain macro 
This supersedes #359 and fixes the fallback domain value when no ingress
host is defined.

Memcached is not used anymore. Postgresql macro has already been fixed
otherwise.

Signed-off-by: justusbunsi <sk.bunsenbrenner@gmail.com>
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 34s
Details
9987aeb4c8
justusbunsi requested review from pat-s 2023-11-13 17:34:30 +00:00
pat-s approved these changes 2023-11-14 22:18:11 +00:00
pat-s left a comment
Member
Copy Link

LGTM, thanks! Nice tests!

LGTM, thanks! Nice tests!
pat-s added 1 commit 2023-11-14 22:18:23 +00:00
Merge branch 'main' into supersede-359
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 1m4s
Details
d3306d71e0
pat-s merged commit 7499fecc1a into main 2023-11-14 22:23:01 +00:00
pat-s referenced this issue from a commit 2023-11-14 22:23:02 +00:00
Fix domain macro (#560)
justusbunsi deleted branch supersede-359 2023-11-16 17:42:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pat-s
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#560
No description provided.
Delete Branch "justusbunsi/helm-chart:supersede-359"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?