Use helm dependency build
in release build
#563
No reviewers
Labels
No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitea/helm-chart#563
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "justusbunsi/helm-chart:build-vs-update"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Using
helm dependency update
may result in unwillingly updating thedependencies while cutting a release. I wasn't able to do so. Most
likely due to the dependency pinning in Chart.yaml and Chart.lock.
Based on Helm documentation,
update
uses Chart.yaml1 whilebuild
uses Chart.lock2.
All in all it is safer to use
helm dependency build
. :Dhttps://helm.sh/docs/helm/helm_dependency_update/ ↩︎
https://helm.sh/docs/helm/helm_dependency_build/ ↩︎
helm dependency build
in release buildInteresting. Shouldn't
Chart.lock
andChart.yaml
be in sync at all times? The former is created from the latter and I don't see howhelm dependency update
would changeChart.yaml
if a fixed version is used.However, if you make a manual change to
Chart.yaml
(e.g. to prepare an update) and runhelm dependency build
, you will get an error:which essentially means: "Use
helm dependency update
".So I wonder: should we just stick to
helm dependency update
? What event motivated you too look into this in the first place?@pat-s I probably confused you with the PR description. What I wanted to say:
Regenerating the
charts
folder is possible with both commandshelm dependency build
andhelm dependency update
.build
command: This is its sole purpose.upgrade
command: Thecharts
folder will be build, but you are usually using this command for updating dependencies.That's similar to
npm install
andnpm update
.The intention of this PR is consistency within our builds. For releasing the chart, we simply need to regenerate the
charts
folder. There is no intention to update dependencies. So it would be consistent to usehelm dependency build
, notupdate
.IMO, the continued usage of
helm dependency update
in our release workflow is risky. Maybe not right now as we have versions in bot Chart.yaml and Chart.lock preventing an unintended update.I got there because I looked up what the release build does - in the context of #564. And then downloaded the released tar.gz file to make sure there was no implicit dependency update.
Using
helm dependency build
eliminates any doubts in the future. 🙂Thanks for the detailed clarification. All clear now!
@techknowlogick You wanna review or shall we merge?
Merging now.