gitea/helm-chart
45
54
Fork 127
Code Issues 31 Pull Requests 8 Actions Releases 87 Activity

add deployment labels to deployment #649

Merged
justusbunsi merged 3 commits from dcrussell/gitea-helm-chart:main into main 2024-05-02 04:43:42 +00:00
Conversation 4 Commits 3 Files Changed 2 +18 -1
dcrussell commented 2024-04-29 16:59:03 +00:00
Contributor
Copy Link

Description of the change

Applies deployment.labels to the deployment itself.

Benefits

Allows the user to add labels to the deployment.

Possible drawbacks

None

Checklist

  • Parameters are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Breaking changes are documented in the README.md
  • Templating unittests are added
### Description of the change Applies `deployment.labels` to the deployment itself. ### Benefits Allows the user to add labels to the deployment. ### Possible drawbacks None ### Checklist <!-- [Place an '[X]' (no spaces) in all applicable fields. Please remove unrelated fields.] --> - [X] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm) - [X] Breaking changes are documented in the `README.md` - [X] Templating unittests are added
dcrussell added 1 commit 2024-04-29 16:59:04 +00:00
add deployment labels to deployment
Some checks failed
check-and-test / check-and-test (pull_request) Has been cancelled
Details
9d4f8d063b
dcrussell requested review from justusbunsi 2024-04-29 16:59:04 +00:00
dcrussell requested review from pat-s 2024-04-29 16:59:04 +00:00
justusbunsi commented 2024-04-29 17:21:43 +00:00
Member
Copy Link

@dcrussell please add a unittest that ensure this feature long-term. Thanks for proposing this addition.

@dcrussell please add a unittest that ensure this feature long-term. Thanks for proposing this addition.
dcrussell added 1 commit 2024-04-29 21:39:26 +00:00
add unittests
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 40s
Details
1c60c23939
dcrussell commented 2024-04-29 21:41:48 +00:00
Author
Contributor
Copy Link

never used helm unittests before. wasn't sure where to add it.. basic seemed sensible to me.

never used helm unittests before. wasn't sure where to add it.. basic seemed sensible to me.
dcrussell commented 2024-05-01 14:57:05 +00:00
Author
Contributor
Copy Link

@justusbunsi am i missing something else on this pr ?

@justusbunsi am i missing something else on this pr ?
justusbunsi commented 2024-05-01 16:57:05 +00:00
Member
Copy Link

@justusbunsi am i missing something else on this pr ?

https://gitea.com/gitea/helm-chart/actions/runs/812/jobs/0 failure is related. Please add the missing empty line at the end. 😆

Otherwise, good to be merged.

> @justusbunsi am i missing something else on this pr ? https://gitea.com/gitea/helm-chart/actions/runs/812/jobs/0 failure is related. Please add the missing empty line at the end. 😆 Otherwise, good to be merged.
😆 1
dcrussell added 1 commit 2024-05-01 23:19:49 +00:00
oh yaml.. add newline
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 35s
Details
7cf9b296e3
justusbunsi approved these changes 2024-05-02 04:42:36 +00:00
justusbunsi left a comment
Member
Copy Link

LGTM

LGTM
justusbunsi merged commit dd304c1c1a into main 2024-05-02 04:43:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pat-s
justusbunsi
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#649
No description provided.
Delete Branch "dcrussell/gitea-helm-chart:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?