gitea/helm-chart
45
54
Fork 127
Code Issues 33 Pull Requests 9 Actions Releases 87 Activity

Move chart version to drone build using tag #93

Merged
techknowlogick merged 2 commits from feat/chart_version into master 2020-12-21 02:05:43 +00:00
Conversation 1 Commits 2 Files Changed 2 +4 -4
lafriks commented 2020-12-18 12:45:47 +00:00
Member
Copy Link

Tag name will automatically be used as chart version removing v prefix.

Tag name will automatically be used as chart version removing `v` prefix.
lafriks added the
kind
build
 label 2020-12-18 12:45:47 +00:00
lafriks added 1 commit 2020-12-18 12:45:48 +00:00
Move chart version to drone build using tag
All checks were successful
continuous-integration/drone/push Build is passing
Details
e2584b412d
luhahn commented 2020-12-18 15:45:54 +00:00
Member
Copy Link

Even though i would like, that we don't need to set the version anymore, it is required for artifact.io:

https://artifacthub.io/packages/helm/gitea/gitea

edit: now that i think about it, im not sure anymore. They might just get the version out of the index on dl.gitea.io

Even though i would like, that we don't need to set the version anymore, it is required for artifact.io: https://artifacthub.io/packages/helm/gitea/gitea edit: now that i think about it, im not sure anymore. They might just get the version out of the index on dl.gitea.io
luhahn approved these changes 2020-12-18 16:26:05 +00:00
Dismissed
luhahn left a comment
Member
Copy Link

Ok tested the version stuff with novum-rgi chart repo. They take all the information out of the uploaded tgz packages.

Ok tested the version stuff with novum-rgi chart repo. They take all the information out of the uploaded tgz packages.
techknowlogick requested changes 2020-12-20 22:55:14 +00:00
Dismissed
techknowlogick left a comment
Owner
Copy Link

few nits, otherwise LGTM

few nits, otherwise LGTM
.drone.yml
@ -42,3 +42,3 @@
steps:
- name: generate-chart
pull: default
pull: always
techknowlogick commented 2020-12-20 22:54:20 +00:00
Owner
Copy Link

Please change back to "default"

Please change back to "default"
lafriks commented 2020-12-20 23:06:10 +00:00
Author
Member
Copy Link

I might not be right but I don't think that's a valid value in drone 1.x, at least I did not find anything in docs about it: https://docs.drone.io/pipeline/docker/syntax/images/

I think that's just backward comapatible artifact from drone 0.8

I might not be right but I don't think that's a valid value in drone 1.x, at least I did not find anything in docs about it: https://docs.drone.io/pipeline/docker/syntax/images/ I think that's just backward comapatible artifact from drone 0.8
Ghost commented 2020-12-21 01:44:10 +00:00
First-time contributor
Copy Link

Pretty sure @techknowlogick just wants you to not pull image on every run so we don't run out of limit on Docker Hub, which is bad because then we'd be using outated image forever.

Pretty sure @techknowlogick just wants you to not pull image on every run so we don't run out of limit on Docker Hub, which is bad because then we'd be using outated image forever.
lafriks marked this conversation as resolved
.drone.yml
@ -54,3 +54,3 @@
- name: upload-chart
pull: default
pull: always
techknowlogick commented 2020-12-20 22:55:03 +00:00
Owner
Copy Link

as above

as above
lafriks marked this conversation as resolved
techknowlogick approved these changes 2020-12-21 02:05:29 +00:00
Dismissed
techknowlogick added 1 commit 2020-12-21 02:05:34 +00:00
Merge branch 'master' into feat/chart_version
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
54819916b5
techknowlogick merged commit 9b2e76c9cf into master 2020-12-21 02:05:43 +00:00
lafriks deleted branch feat/chart_version 2020-12-21 05:52:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
has
backport

  
in progress

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependency

  
kind
deployment

  
kind
docs

  
kind
enhancement

  
kind
feature

  
kind
lint

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
security

  
kind
testing

  
kind
translation

  
kind
ui

  
need
backport

  
priority
critical

  
priority
low

  
priority
maybe

  
priority
medium

  
reviewed
duplicate

  
reviewed
invalid

  
reviewed
wontfix

  
skip-changelog
  
status
blocked

  
status
needs-feedback

  
status
needs-reviews

  
status
wip

  
upstream
gitea

  
upstream
other

No Label
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/helm-chart#93
No description provided.
Delete Branch "feat/chart_version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?