add times ls #242

Closed
opened 2020-10-22 18:15:30 +00:00 by 6543 · 4 comments
Owner

and move listing feature from times into times ls so tea times --help looks nice and this subcomand works same as the others :)

and move listing feature from `times` into `times ls` so `tea times --help` looks nice and this subcomand works same as the others :)
6543 added the
kind
refactor
label 2020-10-22 18:15:50 +00:00
6543 added this to the v0.6.0 milestone 2020-11-08 18:22:01 +00:00
Member

I would like to offer a PR for that if this is ok?

I would like to offer a PR for that if this is ok?
Member

@khmarbaise sure, go for it ;) thanks!

@khmarbaise sure, go for it ;) thanks!
Member

Based on looking into the code there seemed to be one inconsistence (based on my point of view) because times.go named all cmd parts like CmdTrackedTimes... in controdiction to other parts issues.go which are named CmdIssues*

I would have expected to name the cmd in times.go like CmdTimes... instead?

Is there a reason for that? Or do I just not seeing the whole picture?

Based on looking into the code there seemed to be one inconsistence (based on my point of view) because `times.go` named all cmd parts like `CmdTrackedTimes...` in controdiction to other parts `issues.go` which are named `CmdIssues*` I would have expected to name the cmd in `times.go` like `CmdTimes...` instead? Is there a reason for that? Or do I just not seeing the whole picture?
Member

"times" seemed too imprecise for function names, and "tracked times" too long for UX.
¯_(ツ)_/¯

"times" seemed too imprecise for function names, and "tracked times" too long for UX. ¯\_(ツ)_/¯
noerw added the
status/has-pull
label 2020-12-07 00:00:41 +00:00
6543 referenced this issue from a commit 2020-12-07 12:29:49 +00:00
6543 closed this issue 2020-12-07 12:29:49 +00:00
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#242
No description provided.