Pull DetailView: Show more pull informations #271

						
				@ -51,3 +53,3 @@

					}

					print.PullDetails(pr)

					reviews, _, _ := client.ListPullReviews(owner, repo, idx, gitea.ListPullReviewsOptions{})

khmarbaise commented

2020-12-06 22:58:11 +00:00

Just a question:

reviews, _, _ := client.ListPullReviews(owner, repo, idx, gitea.ListPullReviewsOptions{})

This does ignore the returned error from ListPullReviews if I correctly understand that.. so
shouldn't that be changed to populate the error back to the caller? What is here the general
approach in Go? like the following?

reviews, _, err := client.ListPullReviews(owner, repo, idx, gitea.ListPullReviewsOptions{})
if err != nil {
	return err
}

Or do I misunderstand a thing here?

Just a question: ``` reviews, _, _ := client.ListPullReviews(owner, repo, idx, gitea.ListPullReviewsOptions{}) ``` This does ignore the returned error from ListPullReviews if I correctly understand that.. so shouldn't that be changed to populate the error back to the caller? What is here the general approach in Go? like the following? ``` reviews, _, err := client.ListPullReviews(owner, repo, idx, gitea.ListPullReviewsOptions{}) if err != nil { return err } ``` Or do I misunderstand a thing here?

6543 commented

2020-12-06 23:00:56 +00:00

yes it just ignore an error ... since this api is realy new and wont work on old instances

khmarbaise commented

2020-12-06 23:04:12 +00:00

Ok. Just wanted to know because my knowledge in Go is very limited. Thanks for your explanation.

noerw commented

2020-12-06 23:05:20 +00:00

Maybe put that explanation in a code comment for future reference ;)

6543 commented

2020-12-06 23:29:23 +00:00

It now print a error info in the corner bevore the pull detail view is shown ...

noerw marked this conversation as resolved

noerw reviewed 2020-12-06 23:04:03 +00:00

Dismissed

modules/print/pull.go

						
				@ -24,0 +50,4 @@

						}

					}

					if pr.State == gitea.StateOpen && pr.Mergeable {

noerw commented

2020-12-06 23:04:03 +00:00

This check should also verify that the minum amount of reviews are approved, to be in line with the web ui (eg this PR currently shows READY TO MERGE.)

Or is pr.Mergeable about git conflicts? In that case you should print No Conflicts instead

This check should also verify that the minum amount of reviews are approved, to be in line with the web ui (eg this PR currently shows `READY TO MERGE`.) Or is `pr.Mergeable` about git conflicts? In that case you should print `No Conflicts` instead

6543 commented

2020-12-06 23:26:50 +00:00

-> https://github.com/go-gitea/gitea/issues/13879

and yes I think it's a good idear to only show NoConflicts at the moment

-> https://github.com/go-gitea/gitea/issues/13879 and yes I think it's a good idear to only show NoConflicts at the moment

6543 marked this conversation as resolved

6543 added 2 commits 2020-12-06 23:28:23 +00:00

print info if reviews can not be loaded 34d0629210

No Conflicts

continuous-integration/drone/pr Build is passing

Details

1da4c5b636