Pull DetailView: Show more pull informations #271
No reviewers
Labels
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
No Milestone
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitea/tea#271
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "6543/tea:enhance-pullDetailView"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
close #258
demo:
@ -51,3 +53,3 @@
}
print.PullDetails(pr)
reviews, _, _ := client.ListPullReviews(owner, repo, idx, gitea.ListPullReviewsOptions{})
Just a question:
This does ignore the returned error from ListPullReviews if I correctly understand that.. so
shouldn't that be changed to populate the error back to the caller? What is here the general
approach in Go? like the following?
Or do I misunderstand a thing here?
yes it just ignore an error ... since this api is realy new and wont work on old instances
Ok. Just wanted to know because my knowledge in Go is very limited. Thanks for your explanation.
Maybe put that explanation in a code comment for future reference ;)
It now print a error info in the corner bevore the pull detail view is shown ...
@ -24,0 +50,4 @@
}
}
if pr.State == gitea.StateOpen && pr.Mergeable {
This check should also verify that the minum amount of reviews are approved, to be in line with the web ui (eg this PR currently shows
READY TO MERGE
.)Or is
pr.Mergeable
about git conflicts? In that case you should printNo Conflicts
instead-> https://github.com/go-gitea/gitea/issues/13879
and yes I think it's a good idear to only show NoConflicts at the moment