ssh remote with port not matched correctly #380

New Issue

noerw · 2021-07-08T20:45:05Z

noerw commented

2021-07-08 20:45:05 +00:00

If a repo has a remote URL specified as ssh://git@host:port/user/repo, tea can't match the ssh host of a login to the remote, as it assumes ssh urls like git@host:user/repo and does a string split on :

refs:
https://gitea.com/gitea/tea/src/branch/master/modules/context/context.go#L200
https://daunlord.de/tea.txt
https://discord.com/channels/322538954119184384/756593757801021591/859435904372178944

If a repo has a remote URL specified as `ssh://git@host:port/user/repo`, tea can't match the ssh host of a login to the remote, as it assumes ssh urls like `git@host:user/repo` and does a string split on `:` refs: https://gitea.com/gitea/tea/src/branch/master/modules/context/context.go#L200 https://daunlord.de/tea.txt https://discord.com/channels/322538954119184384/756593757801021591/859435904372178944

noerw added the

kind/bug

label 2021-07-08 20:45:05 +00:00

noerw added this to the v0.8.0 milestone 2021-08-24 12:04:16 +00:00

noerw referenced a pull request that will close this issue

2021-08-25 07:46:07 +00:00

Correctly match login by ssh host with port #391

6543 closed this issue

2021-09-06 10:52:35 +00:00

6543 referenced this issue from a commit

2021-09-06 10:52:35 +00:00

Correctly match login by ssh host with port (#391)