Add notifications subcomand #148

Merged
6543 merged 6 commits from 6543/tea:feat_notifications into master 2 years ago
6543 commented 2 years ago
Collaborator

close partly #90

[user@PC tea]$ ./tea notifications
+-------+-------+------------------------------+
| TYPE  | INDEX |            TITLE             |
+-------+-------+------------------------------+
| Issue | #104  | Docker image                 |
| Pull  | #144  | Add subcomand 'pulls create' |
+-------+-------+------------------------------+


[user@PC tea]$ ./tea notifications --all
+-------+-------+------------------------------+------------------+
| TYPE  | INDEX |            TITLE             |    REPOSITORY    |
+-------+-------+------------------------------+------------------+
| Issue | #104  | Docker image                 | gitea/tea        |
| Pull  | #144  | Add subcomand 'pulls create' | gitea/tea        |
| Pull  | #3    | 1.12.2                       | gitea/helm-chart |
| Pull  | #2    | Update licenses              | gitea/helm-chart |
+-------+-------+------------------------------+------------------+
close partly #90 ``` [user@PC tea]$ ./tea notifications +-------+-------+------------------------------+ | TYPE | INDEX | TITLE | +-------+-------+------------------------------+ | Issue | #104 | Docker image | | Pull | #144 | Add subcomand 'pulls create' | +-------+-------+------------------------------+ [user@PC tea]$ ./tea notifications --all +-------+-------+------------------------------+------------------+ | TYPE | INDEX | TITLE | REPOSITORY | +-------+-------+------------------------------+------------------+ | Issue | #104 | Docker image | gitea/tea | | Pull | #144 | Add subcomand 'pulls create' | gitea/tea | | Pull | #3 | 1.12.2 | gitea/helm-chart | | Pull | #2 | Update licenses | gitea/helm-chart | +-------+-------+------------------------------+------------------+ ```
6543 added this to the v0.4.0 milestone 2 years ago
6543 added the kind/feature label 2 years ago
6543 added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
6227f24fce
add notifications subcomand
6543 commented 2 years ago
Poster
Collaborator
NAME:
   tea notifications - show notifications

USAGE:
   tea notifications [command options] [arguments...]

DESCRIPTION:
   show notifications, by default based of the current repo and unread one

OPTIONS:
   --all, -a                  show all notifications of related gitea instance (default: false)
   --page value, -p value     specify page, default is 1 (default: 1)
   --limit value, --lm value  specify limit of items per page (default: 0)
   --repo value, -r value     Repository to interact with. Optional
   --remote value, -R value   Discover Gitea login from remote. Optional
   --login value, -l value    Use a different Gitea login. Optional
   --output value, -o value   Output format. (csv, simple, table, tsv, yaml)
   --help, -h                 show help (default: false)
``` NAME: tea notifications - show notifications USAGE: tea notifications [command options] [arguments...] DESCRIPTION: show notifications, by default based of the current repo and unread one OPTIONS: --all, -a show all notifications of related gitea instance (default: false) --page value, -p value specify page, default is 1 (default: 1) --limit value, --lm value specify limit of items per page (default: 0) --repo value, -r value Repository to interact with. Optional --remote value, -R value Discover Gitea login from remote. Optional --login value, -l value Use a different Gitea login. Optional --output value, -o value Output format. (csv, simple, table, tsv, yaml) --help, -h show help (default: false) ```
6543 added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
ce4ca9e6b2
show read news not supported jet
6543 commented 2 years ago
Poster
Collaborator

note: #90 - at the moment only unread are supported

when go-sdk v0.12.2 will be released we can enhance this feature

note: https://gitea.com/gitea/tea/issues/90#issuecomment-115257 - at the moment only unread are supported when go-sdk v0.12.2 will be released we can enhance this feature
6543 added the status/needs-reviews label 2 years ago
6543 added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
e750441dcb
Merge branch 'master' into feat_notifications
lunny approved these changes 2 years ago
Dismissed
lunny commented 2 years ago
Owner

But notifications is too long, maybe we need a tea alias command or we can change notifications to messages?

But notifications is too long, maybe we need a `tea alias` command or we can change `notifications` to `messages`?
6543 commented 2 years ago
Poster
Collaborator

@lunny news is short alias

@lunny `news` is short alias
lunny commented 2 years ago
Owner

But I think news have different meaning from notifications.

But I think `news` have different meaning from `notifications`.
6543 commented 2 years ago
Poster
Collaborator

suggestions are welcome :)

suggestions are welcome :)
6543 added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
c6deadb205
Merge branch 'master' into feat_notifications
6543 added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
6fcc09f4e5
Merge branch 'master' into feat_notifications
Collaborator

@lunny I think notifications is OK because that is what they are called everywhere else. It wouldn't be worth making it a few char shorter if people always have to remember what the different word we use is.

It also makes it very clear what the command does -- messages and news are not as clear what they do: are they direct messages from other users? news about the gitea instance?

@lunny I think notifications is OK because that is what they are called everywhere else. It wouldn't be worth making it a few char shorter if people always have to remember what the different word we use is. It also makes it very clear what the command does -- messages and news are not as clear what they do: are they direct messages from other users? news about the gitea instance?
mrsdizzie approved these changes 2 years ago
Dismissed
mrsdizzie left a comment
Collaborator

LGTM but I think it doesn't need the news alias since it makes it more confusing that news and notifications would be the same thing.

Maybe you will want news for something else latter too -- like what if a Gitea admin could post news about the site for all users to see? like "We've updated to a new version with these features..." or "We've changed the repository limit please see our blog post.."

LGTM but I think it doesn't need the news alias since it makes it more confusing that news and notifications would be the same thing. Maybe you will want news for something else latter too -- like what if a Gitea admin could post news about the site for all users to see? like "We've updated to a new version with these features..." or "We've changed the repository limit please see our blog post.."
6543 removed the status/needs-reviews label 2 years ago
6543 commented 2 years ago
Poster
Collaborator

I'll leave it unmerged for some more time - if I got a good idear for a short alias

I'll leave it unmerged for some more time - if I got a good idear for a short alias
6543 added 1 commit 2 years ago
continuous-integration/drone/pr Build is passing Details
745d480855
rm Aliase news for now
6543 referenced this issue from a commit 2 years ago
6543 merged commit 19ee32168e into master 2 years ago
6543 deleted branch feat_notifications 2 years ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 19ee32168e.
Sign in to join this conversation.
Loading…
There is no content yet.