gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

Add notifications subcomand #148

Merged
6543 merged 6 commits from 6543/tea:feat_notifications into master 2020-07-17 15:30:05 +00:00
Conversation 8 Commits 6 Files Changed 2 +111
6543 commented 2020-07-14 09:58:46 +00:00
Owner
Copy Link

close partly #90

[user@PC tea]$ ./tea notifications
+-------+-------+------------------------------+
| TYPE  | INDEX |            TITLE             |
+-------+-------+------------------------------+
| Issue | #104  | Docker image                 |
| Pull  | #144  | Add subcomand 'pulls create' |
+-------+-------+------------------------------+


[user@PC tea]$ ./tea notifications --all
+-------+-------+------------------------------+------------------+
| TYPE  | INDEX |            TITLE             |    REPOSITORY    |
+-------+-------+------------------------------+------------------+
| Issue | #104  | Docker image                 | gitea/tea        |
| Pull  | #144  | Add subcomand 'pulls create' | gitea/tea        |
| Pull  | #3    | 1.12.2                       | gitea/helm-chart |
| Pull  | #2    | Update licenses              | gitea/helm-chart |
+-------+-------+------------------------------+------------------+
close partly #90 ``` [user@PC tea]$ ./tea notifications +-------+-------+------------------------------+ | TYPE | INDEX | TITLE | +-------+-------+------------------------------+ | Issue | #104 | Docker image | | Pull | #144 | Add subcomand 'pulls create' | +-------+-------+------------------------------+ [user@PC tea]$ ./tea notifications --all +-------+-------+------------------------------+------------------+ | TYPE | INDEX | TITLE | REPOSITORY | +-------+-------+------------------------------+------------------+ | Issue | #104 | Docker image | gitea/tea | | Pull | #144 | Add subcomand 'pulls create' | gitea/tea | | Pull | #3 | 1.12.2 | gitea/helm-chart | | Pull | #2 | Update licenses | gitea/helm-chart | +-------+-------+------------------------------+------------------+ ```
👍 1
6543 added this to the v0.4.0 milestone 2020-07-14 09:58:46 +00:00
6543 added the
kind
feature
 label 2020-07-14 09:58:46 +00:00
6543 added 1 commit 2020-07-14 09:58:48 +00:00
add notifications subcomand
All checks were successful
continuous-integration/drone/pr Build is passing
Details
6227f24fce
6543 commented 2020-07-14 10:00:23 +00:00
Author
Owner
Copy Link
NAME:
   tea notifications - show notifications

USAGE:
   tea notifications [command options] [arguments...]

DESCRIPTION:
   show notifications, by default based of the current repo and unread one

OPTIONS:
   --all, -a                  show all notifications of related gitea instance (default: false)
   --page value, -p value     specify page, default is 1 (default: 1)
   --limit value, --lm value  specify limit of items per page (default: 0)
   --repo value, -r value     Repository to interact with. Optional
   --remote value, -R value   Discover Gitea login from remote. Optional
   --login value, -l value    Use a different Gitea login. Optional
   --output value, -o value   Output format. (csv, simple, table, tsv, yaml)
   --help, -h                 show help (default: false)
``` NAME: tea notifications - show notifications USAGE: tea notifications [command options] [arguments...] DESCRIPTION: show notifications, by default based of the current repo and unread one OPTIONS: --all, -a show all notifications of related gitea instance (default: false) --page value, -p value specify page, default is 1 (default: 1) --limit value, --lm value specify limit of items per page (default: 0) --repo value, -r value Repository to interact with. Optional --remote value, -R value Discover Gitea login from remote. Optional --login value, -l value Use a different Gitea login. Optional --output value, -o value Output format. (csv, simple, table, tsv, yaml) --help, -h show help (default: false) ```
6543 added 1 commit 2020-07-14 10:02:56 +00:00
show read news not supported jet
All checks were successful
continuous-integration/drone/pr Build is passing
Details
ce4ca9e6b2
6543 commented 2020-07-14 14:55:07 +00:00
Author
Owner
Copy Link

note: #90 (comment) - at the moment only unread are supported

when go-sdk v0.12.2 will be released we can enhance this feature

note: https://gitea.com/gitea/tea/issues/90#issuecomment-115257 - at the moment only unread are supported when go-sdk v0.12.2 will be released we can enhance this feature
6543 added the
status/needs-reviews
 label 2020-07-14 14:58:02 +00:00
6543 added 1 commit 2020-07-16 15:03:16 +00:00
Merge branch 'master' into feat_notifications
All checks were successful
continuous-integration/drone/pr Build is passing
Details
e750441dcb
lunny approved these changes 2020-07-16 15:22:45 +00:00
Dismissed
lunny commented 2020-07-16 15:23:30 +00:00
Owner
Copy Link

But notifications is too long, maybe we need a tea alias command or we can change notifications to messages?

But notifications is too long, maybe we need a `tea alias` command or we can change `notifications` to `messages`?
6543 commented 2020-07-16 15:27:54 +00:00
Author
Owner
Copy Link

@lunny news is short alias

@lunny `news` is short alias
lunny commented 2020-07-16 15:34:20 +00:00
Owner
Copy Link

But I think news have different meaning from notifications.

But I think `news` have different meaning from `notifications`.
6543 commented 2020-07-16 15:36:06 +00:00
Author
Owner
Copy Link

suggestions are welcome :)

suggestions are welcome :)
6543 added 1 commit 2020-07-16 18:35:02 +00:00
Merge branch 'master' into feat_notifications
All checks were successful
continuous-integration/drone/pr Build is passing
Details
c6deadb205
6543 added 1 commit 2020-07-17 09:15:02 +00:00
Merge branch 'master' into feat_notifications
All checks were successful
continuous-integration/drone/pr Build is passing
Details
6fcc09f4e5
mrsdizzie commented 2020-07-17 13:38:08 +00:00
Member
Copy Link

@lunny I think notifications is OK because that is what they are called everywhere else. It wouldn't be worth making it a few char shorter if people always have to remember what the different word we use is.

It also makes it very clear what the command does -- messages and news are not as clear what they do: are they direct messages from other users? news about the gitea instance?

@lunny I think notifications is OK because that is what they are called everywhere else. It wouldn't be worth making it a few char shorter if people always have to remember what the different word we use is. It also makes it very clear what the command does -- messages and news are not as clear what they do: are they direct messages from other users? news about the gitea instance?
mrsdizzie approved these changes 2020-07-17 13:41:07 +00:00
Dismissed
mrsdizzie left a comment
Member
Copy Link

LGTM but I think it doesn't need the news alias since it makes it more confusing that news and notifications would be the same thing.

Maybe you will want news for something else latter too -- like what if a Gitea admin could post news about the site for all users to see? like "We've updated to a new version with these features..." or "We've changed the repository limit please see our blog post.."

LGTM but I think it doesn't need the news alias since it makes it more confusing that news and notifications would be the same thing. Maybe you will want news for something else latter too -- like what if a Gitea admin could post news about the site for all users to see? like "We've updated to a new version with these features..." or "We've changed the repository limit please see our blog post.."
6543 removed the
status/needs-reviews
 label 2020-07-17 14:27:28 +00:00
6543 commented 2020-07-17 14:28:04 +00:00
Author
Owner
Copy Link

I'll leave it unmerged for some more time - if I got a good idear for a short alias

I'll leave it unmerged for some more time - if I got a good idear for a short alias
6543 added 1 commit 2020-07-17 15:27:06 +00:00
rm Aliase news for now
All checks were successful
continuous-integration/drone/pr Build is passing
Details
745d480855
6543 merged commit 19ee32168e into master 2020-07-17 15:30:05 +00:00
6543 deleted branch feat_notifications 2020-07-17 15:30:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.4.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#148
No description provided.
Delete Branch "6543/tea:feat_notifications"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?