gitea/tea
gitea/tea
57
129
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

Add milestones subcomands #149

Merged
6543 merged 18 commits from 6543/tea:feat_milestones into master 2020-09-17 19:35:25 +00:00
Conversation 6 Commits 18 Files Changed 5 +5 -7
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fa1a976e41 - Show all commits

12
cmd/milestones.go
View File

@ -59,7 +59,7 @@ func runMilestoneDetail(ctx *cli.Context, value string) error {
login, owner, repo := initCommand()
client := login.Client()
mileID, err := getMileIDbyNameOrID(client, owner, repo, value)
mileID, err := getMilestoneID(client, owner, repo, value)
if err != nil {
return err
}
@ -215,7 +215,7 @@ func editMilestoneStatus(ctx *cli.Context, close bool) error {
login, owner, repo := initCommand()
client := login.Client()
mileID, err := getMileIDbyNameOrID(client, owner, repo, ctx.Args().First())
mileID, err := getMilestoneID(client, owner, repo, ctx.Args().First())
if err != nil {
return err
}
@ -247,7 +247,7 @@ func deleteMilestone(ctx *cli.Context) error {
login, owner, repo := initCommand()
client := login.Client()
mileID, err := getMileIDbyNameOrID(client, owner, repo, ctx.Args().First())
mileID, err := getMilestoneID(client, owner, repo, ctx.Args().First())
if err != nil {
return err
}
@ -268,13 +268,11 @@ var CmdMilestonesReopen = cli.Command{
Flags: AllDefaultFlags,
}
func getMileIDbyNameOrID(client *gitea.Client, owner, repo, nameOrID string) (int64, error) {
// getMilestoneID TODO: delete it and use sdk feature when v0.13.0 is released
zeripath commented 2020-09-14 13:52:15 +00:00
Outdated
Review
Copy Link

I'm really not a fan of this function name. What's wrong with just getMilestoneID?

I'm really not a fan of this function name. What's wrong with just getMilestoneID?
6543 commented 2020-09-14 14:38:53 +00:00
Outdated
Review
Copy Link

I'll refactor it to getMilestone because List return a full usable milestone ...

I'll refactor it to **getMilestone** because List return a full usable milestone ...
6543 commented 2020-09-14 15:07:39 +00:00
Outdated
Review
Copy Link

getMilestoneID is fine, beside MilestoneDetails only ID is needed ...

getMilestoneID is fine, beside MilestoneDetails only ID is needed ...
func getMilestoneID(client *gitea.Client, owner, repo, nameOrID string) (int64, error) {
if match, err := regexp.MatchString("^\\d+$", nameOrID); err == nil && match {
return strconv.ParseInt(nameOrID, 10, 64)
}
// since there is no API to resolve it we have to iterate all milestones :/
// https://gitea.com/gitea/go-sdk/issues/383
i := 0
for {
i++